Skip to content

gh-151593: Temporarily allow the TSan (free-threading) job to fail#152173

Draft
StanFromIreland wants to merge 3 commits into
python:mainfrom
StanFromIreland:test_abstractmethod_integration
Draft

gh-151593: Temporarily allow the TSan (free-threading) job to fail#152173
StanFromIreland wants to merge 3 commits into
python:mainfrom
StanFromIreland:test_abstractmethod_integration

Conversation

@StanFromIreland

@StanFromIreland StanFromIreland commented Jun 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Member

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2026
Open
@StanFromIreland StanFromIreland requested a review from vstinner June 25, 2026 09:13
@StanFromIreland StanFromIreland mentioned this pull request Jun 25, 2026
Merged
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Oh, another race-condition in test_ssl. I think we can mark this job as optional instead.

@StanFromIreland StanFromIreland changed the title gh-151593: Skip test_abc.test_abstractmethod_integration on free-threading gh-151593: Temporarily allow the TSan (free-threading) job to fail Jun 25, 2026
@StanFromIreland StanFromIreland added the needs backport to 3.15 pre-release feature fixes, bugs and security fixes label Jun 25, 2026
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

Also blocking various 3.15 backports, e.g. https://github.com/python/cpython/actions/runs/28159079945/job/83394836968?pr=152169.

@vstinner

vstinner commented Jun 25, 2026

Copy link
Copy Markdown
Member

The issue is quite serious, it's a real deadlock in the dict implementation! If possible, I would prefer to not skip the test (to not forget about it), but fix the deadlock instead. But I totally agree that this bug is really annoying (it makes the CI quite often).

I created #152200 to fix the deadlock.

@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member Author

I would prefer to not skip the test (to not forget about it)

I don't think we'd forget, it would still run and fail, leaving it at the top of the list:

image

Marking this as draft considering there's a patch, but if that gets delayed I'll reconsider.

@StanFromIreland StanFromIreland marked this pull request as draft June 25, 2026 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vstinner vstinner Awaiting requested review from vstinner
@ezio-melotti ezio-melotti Awaiting requested review from ezio-melotti ezio-melotti is a code owner
@hugovk hugovk Awaiting requested review from hugovk hugovk is a code owner
@AA-Turner AA-Turner Awaiting requested review from AA-Turner AA-Turner is a code owner
@webknjaz webknjaz Awaiting requested review from webknjaz webknjaz is a code owner
@itamaro itamaro Awaiting requested review from itamaro itamaro is a code owner
@JacobCoffee JacobCoffee Awaiting requested review from JacobCoffee JacobCoffee is a code owner

Assignees

No one assigned

Labels

needs backport to 3.15 pre-release feature fixes, bugs and security fixes skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@StanFromIreland @vstinner