Skip to content

gh-152168: Don't skip test_bigmem if _testcapi is missing#152171

Merged
StanFromIreland merged 1 commit into
python:mainfrom
ShaharNaveh:bigmem-testcapi-skip
Jun 25, 2026
Merged

gh-152168: Don't skip test_bigmem if _testcapi is missing#152171
StanFromIreland merged 1 commit into
python:mainfrom
ShaharNaveh:bigmem-testcapi-skip

Conversation

@ShaharNaveh

@ShaharNaveh ShaharNaveh commented Jun 25, 2026 •
edited by bedevere-app Bot
Loading

Copy link
Copy Markdown
Contributor

@bedevere-app bedevere-app Bot added the tests Tests in the Lib/test dir label Jun 25, 2026
@bedevere-app bedevere-app Bot mentioned this pull request Jun 25, 2026
Closed
@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

!buildbot bigmem

@bedevere-bot

bedevere-bot commented Jun 25, 2026

Copy link
Copy Markdown

🤖 New build scheduled with the buildbot fleet by @StanFromIreland for commit 7f0b2e3 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F152171%2Fmerge

The command will test the builders whose names match following regular expression: bigmem

The builders matched are:

  • aarch64 Ubuntu 24.04 BigMem PR

@StanFromIreland StanFromIreland self-assigned this Jun 25, 2026
@ShaharNaveh

ShaharNaveh commented Jun 25, 2026

Copy link
Copy Markdown
Contributor Author

test failures seems unrelated, right? 😕

@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

Don't worry, I've been playing the TSan lottery all week 🙃 I have a PR to skip it.

@StanFromIreland

StanFromIreland commented Jun 25, 2026

Copy link
Copy Markdown
Member

The test_zipfile64 fail on the buildbot is #152190, test_bigmem passes.

@StanFromIreland StanFromIreland added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes needs backport to 3.15 pre-release feature fixes, bugs and security fixes labels Jun 25, 2026
@StanFromIreland StanFromIreland merged commit 6a82832 into python:main Jun 25, 2026
103 of 106 checks passed
@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Thanks @ShaharNaveh for the PR, and @StanFromIreland for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14, 3.15.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington-app

miss-islington-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

Sorry, @ShaharNaveh and @StanFromIreland, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 6a82832a0bd12ff6154fcfcccc3b7b5644eab0e8 3.13

@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152198 is a backport of this pull request to the 3.15 branch.

@bedevere-app

bedevere-app Bot commented Jun 25, 2026

Copy link
Copy Markdown

GH-152199 is a backport of this pull request to the 3.14 branch.

@bedevere-app bedevere-app Bot removed needs backport to 3.15 pre-release feature fixes, bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jun 25, 2026
@StanFromIreland StanFromIreland removed the needs backport to 3.13 bugs and security fixes label Jun 25, 2026
StanFromIreland pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington @ShaharNaveh
[3.15] gh-152168: Don't skip test_bigmem if _testcapi is missing (G…
06e6515 
…H-152171) (#152198)

(cherry picked from commit 6a82832)

Co-authored-by: Shahar Naveh <50263213+ShaharNaveh@users.noreply.github.com>
StanFromIreland pushed a commit that referenced this pull request Jun 25, 2026
@miss-islington @ShaharNaveh
[3.14] gh-152168: Don't skip test_bigmem if _testcapi is missing (G…
a1e057b 
…H-152171) (#152199)

(cherry picked from commit 6a82832)

Co-authored-by: Shahar Naveh <50263213+ShaharNaveh@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

Assignees

@StanFromIreland StanFromIreland

Labels

skip news tests Tests in the Lib/test dir

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ShaharNaveh @StanFromIreland @bedevere-bot