feat(render): clouds, foliage wind, additive fog, immediate-mode shadows, Windows fixes#69
Merged
Merged
Conversation
…te-mode, Windows fixes Rendering features behind the shooter's visual pass: - Sky: analytic drifting cloud layer in the procedural-sky shader (env.rs); time fed via the unused SkyUniforms.intensity.y. - Fog: manual height-fog march now runs additively with procedural sky (post.rs) instead of only as the aerial-LUT else-branch, so haze works at sub-km scene scale. - Foliage: wind sway + backlit translucency for alpha-cutout materials in the scene shader (core.rs); wind appended to LightingUniforms (types.rs) with widened UBO visibility (lighting.rs, mod.rs). - Shadows: shadow pass renders immediate-mode + cached-model draws, not just scene nodes (shadow_pass.rs), so immediate-mode games cast shadows. - Device: raise max_sampled_textures/samplers per stage to the adapter max so refractive materials (19 sampled textures) compile (windows). - FFI: bloom_set_bloom_intensity/tonemap/auto_exposure_*, mesh scratch-buffer upload (createMesh i64 ABI fix), drawModelRotated re-export (visual.rs, models.rs, src/*). - Windows build: jolt default features, panic=abort, Jolt libDirs, LTCG off for lld-link (build.rs, Cargo.toml, package.json).
added 3 commits
June 16, 2026 20:53
Trees/grass/leaves cast opaque rest-pose blobs because the shadow pass is depth-only. Added a SECOND shadow pipeline (pipeline_cutout, SHADOW_SHADER_CUTOUT) that samples the caster's base-colour alpha and discards below the material cutoff, so cutout cards drop their real (dappled) shape. The opaque shadow pipeline is byte-identical/untouched — only cutout cached models use the new path. GpuMesh gains a per-mesh cutout shadow bind group (base colour + sampler + cutoff), built in cache_model_if_static for alpha_cutoff>0; shadow_pass.rs selects the pipeline per caster and binds group 1 for cutout entries.
The planar reflection probe only rendered material-system draws, so immediate-mode games (which draw the world via drawModel) got a black/empty probe. Added a single-target reflection pipeline (REFLECT_SCENE_WGSL: base-colour x sun N.L + ambient, alpha-cutout discard) that renders every cached model (trees, house, foliage) into the probe with a mirrored, oblique-clipped VP. Owned bind-group layouts (dynamic per-draw model uniform + sun/ambient); reuses scene_material_bg for base colour. Probe clears to transparent so geometry writes alpha 1 and the water shader blends the probe over its analytic sky dome by alpha. Lazily built on first dispatch; no change to the opaque/main pass.
The planar-reflection scene shader negated the sun dir for N.L, which only matched when the caller passed a below-horizon (travel-direction) sun. Engine convention is direction-TO-sun everywhere (scene diffuse, shadow fit, sky LUT mu_s=sun.y), so use +sun_dir.
proggeramlug
added a commit
that referenced
this pull request
Jun 22, 2026
The ffi-parity check was already red on main (29 failures): #69 added the mesh-scratch / tonemap / bloom-intensity / auto-exposure FFI functions and #70 added bloom_attach_hwnd / bloom_resize to the shared manifest, but neither was exported (or allowlisted) on the platforms that don't pick them up automatically. The manifest contract requires every platform to export every entry, so the attach PR can't go green without closing them. - bloom_resize: real on macOS/iOS/tvOS/visionOS/Android/Linux — it just forwards to the shared Renderer::resize (same body as the Windows impl from #70), so host-driven BloomView resizing now works on every target, not only Windows. - bloom_attach_hwnd: no-op stub on the non-Windows native platforms (it's HWND-specific; those hosts use bloom_attach_native). Mirrors #70's own cfg(not(windows)) no-op. - watchos: regenerated ffi_stubs.rs covers the new entries. - web: documented the genuinely-unimplemented entries in tools/validate-ffi.js WEB_GAP_ALLOWLIST (pointer-taking mesh scratch = same WASM linear-memory TODO as bloom_scene_set_lod; post-FX controls not yet wired in the web crate; attach_hwnd N/A on canvas). validate-ffi now passes 0 failures / 0 warnings across all 8 platforms. macOS rebuilds + renders a scene end-to-end; iOS cross-compiles.
proggeramlug
added a commit
that referenced
this pull request
Jun 22, 2026
renderer/mod.rs grew to 11985 lines in #69 (clouds / foliage wind / additive fog / immediate-mode shadows) but the ratcheting file-lines baseline was left at 11775, leaving check-file-lines red on main. Record the new grandfathered size so the gate is green; the baseline still only ratchets down from here. No code change.
proggeramlug
added a commit
that referenced
this pull request
Jun 22, 2026
…y#5519) (#71) * feat(attach): host-surface attach path on all platforms (PerryTS/perry#5519) Add a per-platform "attach to a host-provided surface" entry point so a BloomView (Perry UI) can hand the engine a native view/window/surface it already owns, instead of the engine creating its own window. Previously only Windows could embed (via the engine#70 bloom_attach_hwnd work); every other target created a view but no renderer attached to it. Engine - native/shared/src/attach.rs: factor the wgpu bring-up — instance → surface → adapter → device → swapchain → Renderer → EngineState — duplicated in every platform's bloom_init_window into one attach_engine() helper, parameterised by backend bitmask, dimensions (logical + physical for HiDPI), and a FormatPreference (Srgb / NonSrgb / First) covering each platform's swapchain-format policy. Returns a Result instead of panicking so a host attaching to a not-yet-realized view can recover. - One unified ABI symbol bloom_attach_native(handle, w, h) -> f64 rather than distinct per-platform names: the function manifest is shared and validate-ffi requires every platform to export every entry, so a single symbol (each platform interpreting `handle` as its own view/window/surface pointer) is cleaner than N stubs. TS exposes the named wrappers attachToNSView / attachToUIView / attachToSurface + attachToNativeView, all forwarding to it. - macOS: bloom_init_window refactored to use attach_engine (proves the factoring) + real bloom_attach_native on a host NSView. - iOS / tvOS / visionOS: real attach on a host UIView (tvOS/visionOS use a non-sRGB swapchain to match their windowed path). - Android: real attach on a host ANativeWindow. - Windows: real attach on a host HWND. - Linux: documented stub returning 0 — GTK4 GtkWidget→GdkSurface bridging is the larger follow-up the issue calls out. - watchOS: regenerated no-op stub (no wgpu). web: wasm_bindgen no-op (web builds its surface from the canvas id). - package.json manifest entry; validate-ffi passes 0/0 across all 8 platforms. Verification - shared compiles (native + wasm32); macОS builds and renders a scene end-to-end headless (getScreenWidth/Height read back 320x240 from the attached EngineState, 30 frames, clean exit); iOS cross-compiles; web wasm32 checks. Android/Linux/Windows cross-builds blocked locally by missing C cross-toolchains (NDK / linux-gcc / MSVC), not by this code. * chore(ffi): close pre-existing ffi-parity gaps so CI is green The ffi-parity check was already red on main (29 failures): #69 added the mesh-scratch / tonemap / bloom-intensity / auto-exposure FFI functions and #70 added bloom_attach_hwnd / bloom_resize to the shared manifest, but neither was exported (or allowlisted) on the platforms that don't pick them up automatically. The manifest contract requires every platform to export every entry, so the attach PR can't go green without closing them. - bloom_resize: real on macOS/iOS/tvOS/visionOS/Android/Linux — it just forwards to the shared Renderer::resize (same body as the Windows impl from #70), so host-driven BloomView resizing now works on every target, not only Windows. - bloom_attach_hwnd: no-op stub on the non-Windows native platforms (it's HWND-specific; those hosts use bloom_attach_native). Mirrors #70's own cfg(not(windows)) no-op. - watchos: regenerated ffi_stubs.rs covers the new entries. - web: documented the genuinely-unimplemented entries in tools/validate-ffi.js WEB_GAP_ALLOWLIST (pointer-taking mesh scratch = same WASM linear-memory TODO as bloom_scene_set_lod; post-FX controls not yet wired in the web crate; attach_hwnd N/A on canvas). validate-ffi now passes 0 failures / 0 warnings across all 8 platforms. macOS rebuilds + renders a scene end-to-end; iOS cross-compiles. * chore(ci): grandfather renderer/mod.rs at 11985 lines (#69 growth) renderer/mod.rs grew to 11985 lines in #69 (clouds / foliage wind / additive fog / immediate-mode shadows) but the ratcheting file-lines baseline was left at 11775, leaving check-file-lines red on main. Record the new grandfathered size so the gate is green; the baseline still only ratchets down from here. No code change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rendering features added while building the Bloom Shooter's visual pass on Windows.
Sky
env.rs). Per-pixel view ray projected onto a virtual cloud plane (perspective convergence at the horizon), value-noise fBm coverage, faded near horizon + thinned around the sun. Time is fed through the previously-unusedSkyUniforms.intensity.y(no struct-layout change) so the clouds drift.Fog
post.rs) instead of only as theelseof the aerial-perspective branch. The procedural aerial LUT is km-scaled and negligible over a small (tens-of-metres) scene, so this restores controllable haze at scene scale. Guarded to skip sky pixels.Foliage
core.rs), gated on the cutout flag so opaque geometry is untouched.wind: vec4appended toLightingUniforms(types.rs); UBO visibility widened to VERTEX_FRAGMENT (lighting.rs,mod.rs).Shadows
shadow_pass.rs). Immediate-mode games (drawCube/drawModel) created no scene nodes and so cast no shadows before.Materials / device
max_sampled_textures_per_shader_stage+max_samplers_per_shader_stageto the adapter maximum (windows device request). The refractive material profile binds 19 sampled textures in the fragment stage; the default limit of 16 made it fail to compile.FFI
bloom_set_bloom_intensity/tonemap/auto_exposure_key/auto_exposure_rate; mesh scratch-buffer upload path (works around the createMesh i64 ABI break on Perry 0.5.1171);drawModelRotatedre-export from the main index (visual.rs,models.rs,src/*).Windows build
panic = abort, JoltlibDirs, and LTCG off so lld-link can read the Jolt objects (build.rs,Cargo.toml,package.json).Paired with Bloom-Engine/shooter PR (the visual overhaul that consumes these).