Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -13,11 +13,11 @@ jobs:
matrix:
node: [20, 22, 24]
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 7.0.0

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 actions/checkout pinned to 7.0.0, not 6.0.3 as described

The PR description's table lists the target version for actions/checkout as 6.0.3 (with 7.0.0 as "Pending"), but the SHA 9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 corresponds to 7.0.0 per the inline comment. Renovate appears to have updated the pinned SHA after generating the PR description. The same discrepancy exists in release.yml and socket-tier1-analysis.yml. This means merging this PR will actually adopt actions/checkout@7.0.0, not 6.0.3 — reviewers should evaluate the 7.0.0 changelog (not just 6.0.3) before approving.

Prompt To Fix With AI
This is a comment left during a code review.
Path: .github/workflows/ci.yml
Line: 16

Comment:
**`actions/checkout` pinned to `7.0.0`, not `6.0.3` as described**

The PR description's table lists the target version for `actions/checkout` as `6.0.3` (with `7.0.0` as "Pending"), but the SHA `9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0` corresponds to `7.0.0` per the inline comment. Renovate appears to have updated the pinned SHA after generating the PR description. The same discrepancy exists in `release.yml` and `socket-tier1-analysis.yml`. This means merging this PR will actually adopt `actions/checkout@7.0.0`, not `6.0.3` — reviewers should evaluate the `7.0.0` changelog (not just `6.0.3`) before approving.

How can I resolve this? If you propose a fix, please make it concise.


- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
- uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # 6.0.9

- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # 6.4.0
with:
node-version: ${{ matrix.node }}
cache: pnpm
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/release-please.yml
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ jobs:
release_created: ${{ steps.release.outputs.release_created }}
tag_name: ${{ steps.release.outputs.tag_name }}
steps:
- uses: googleapis/release-please-action@5c625bfb5d1ff62eadeeb3772007f7f66fdcf071 # v4
- uses: googleapis/release-please-action@45996ed1f6d02564a971a2fa1b5860e934307cf7 # 5.0.0
id: release
with:
token: ${{ secrets.GITHUB_TOKEN }}
Expand Down
6 changes: 3 additions & 3 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ jobs:
contents: read
id-token: write
steps:
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
- uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 7.0.0

- uses: pnpm/action-setup@b906affcce14559ad1aafd4ab0e942779e9f58b1 # v4
- uses: pnpm/action-setup@0ebf47130e4866e96fce0953f49152a61190b271 # 6.0.9

- uses: actions/setup-node@49933ea5288caeca8642d1e84afbd3f7d6820020 # v4
- uses: actions/setup-node@48b55a011bda9f5d6aeb4c2d9c7362e8dae4041e # 6.4.0
with:
node-version: 24
registry-url: 'https://registry.npmjs.org'
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/socket-tier1-analysis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ jobs:
run: |
echo "distinct_id: ${{ github.event.inputs.distinct_id }}"
- name: Checkout code
uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 7.0.0
- name: Install Socket CLI
run: npm install -g socket
- name: Run Tier 1 reachability scan
Expand Down