Resolve GuzzleHttp\Exception\RequestException error#1168
Open
dati18 wants to merge 9 commits into
Open
Conversation
dati18
force-pushed
the
fix-guzzelhttp-error
branch
from
c75d943 to
db8eaba
Compare
dati18
force-pushed
the
fix-guzzelhttp-error
branch
from
db8eaba to
e74a997
Compare
dati18
force-pushed
the
fix-guzzelhttp-error
branch
from
373a022 to
5287a4a
Compare
Contributor
|
@dati18 Do you think there are any other places that we also need to ensure we've made this change? From my quick looking I would expect us to need to think about at least our elasticsearch and queryservice hosts too. Do you agree? For example:
Both of these get their host source from environment variables without a scheme: An idea I had was to ensure that a scheme is specified when then config is parsed. If it's not we could then either add |
dati18
force-pushed
the
fix-guzzelhttp-error
branch
from
777f30d to
ac2c9bb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bumping guzzlehttp/guzzle from 7.10.5 to 7.12.0 triggered a bunch of error
The stack trace pointed to line 21 and 30 of PollForMediaWikiJob
The investigation is documented here.
Bug: T429593