feat(auth): server-issued wallet auth challenge#402
Draft
Ryanmello07 wants to merge 9 commits into
Draft
Conversation
Replace hardcoded signature placeholders with locally generated Solana keypairs so the happy path and replay/timestamp tests exercise real signature verification against the server-issued challenge.
Replace the environment-specific TEMPLATE=template_utf8 with the built-in TEMPLATE='template0' so wallet auth challenge tests (and all other integration tests) can create temp DBs on any standard PostgreSQL install without a custom template database.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace client-generated wallet login messages with a server-issued, single-use, expiring challenge to prevent replay attacks.
What's new
wallet_auth_challengetable + index.POST /auth/wallet-challengeendpoint returns{ challenge, timestamp, expires_in, message_template }.UseWalletAuthChallengeverifies:/auth/login) and wallet network create (/auth/network-create) now require a valid challenge.Security properties
Review notes
WARP_ENV/pg.yml) which is not available in this container;go build ./...andgo vet ./model/...pass locally.