Skip to content

Correct hstar being stored on data structure#4396

Open
timothy-nunn wants to merge 1 commit into
mainfrom
hstar-saved-incorrectly
Open

Correct hstar being stored on data structure#4396
timothy-nunn wants to merge 1 commit into
mainfrom
hstar-saved-incorrectly

Conversation

@timothy-nunn

Copy link
Copy Markdown
Collaborator

I think hstar is being incorrectly set on the data structure in calculate_confinement_time. calculate_confinement_time is also called when creating the H-factor table for the OUT.DAT. I believe that the hstar from this is what was being written to the MFILE, not the hstar from the selected confinement scaling.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 48.84%. Comparing base (e24884c) to head (5d58edc).

Files with missing lines Patch % Lines
process/models/physics/confinement_time.py 25.00% 3 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4396   +/-   ##
=======================================
  Coverage   48.84%   48.84%           
=======================================
  Files         151      151           
  Lines       29377    29377           
=======================================
  Hits        14348    14348           
  Misses      15029    15029           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@timothy-nunn timothy-nunn marked this pull request as ready for review June 29, 2026 15:15
@timothy-nunn timothy-nunn requested a review from a team as a code owner June 29, 2026 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants