[2/N] feat(runway): add Merger extension interface, mock, and noop impl#250
Open
kevinlnew wants to merge 2 commits into
Open
[2/N] feat(runway): add Merger extension interface, mock, and noop impl#250kevinlnew wants to merge 2 commits into
kevinlnew wants to merge 2 commits into
Conversation
This was referenced Jun 16, 2026
kevinlnew
changed the title
kevinlnew
changed the title
kevinlnew
force-pushed
the
runway/entities
branch
from
706acff to
6ab03eb
Compare
kevinlnew
force-pushed
the
runway/vcs-extension
branch
from
05a53c0 to
7aa8d2d
Compare
kevinlnew
force-pushed
the
runway/entities
branch
from
6ab03eb to
fb3412c
Compare
kevinlnew
force-pushed
the
runway/vcs-extension
branch
2 times, most recently
from
bf2831f to
ac42742
Compare
kevinlnew
changed the title
kevinlnew
requested review from
a team,
behinddwalls and
sbalabanov
as code owners
| CheckMergeability(ctx context.Context, req entity.MergeRequest) (entity.MergeResult, error) | ||
| // Land applies the ordered steps, commits the result to the remote, and | ||
| // reports per-step OutputIDs (the VCS-neutral revision identifiers produced). | ||
| Land(ctx context.Context, req entity.MergeRequest) (entity.MergeResult, error) |
Collaborator
There was a problem hiding this comment.
should we just call it Merge
| // VCS performs version-control operations against a single landing target. | ||
| // Both methods accept the same MergeRequest payload; the behavioral difference | ||
| // is whether the result is committed to the remote. | ||
| type VCS interface { |
Collaborator
There was a problem hiding this comment.
Should we just call it Merger?
Add the pluggable VCS extension for Runway with the Merger interface (CheckMergeability + Merge), using the landed proto-based MergeRequest/ MergeResult types from api/runway/messagequeue. Includes noop impl with synthetic output IDs, generated mock, and table-driven tests. Addresses review feedback: renamed VCS -> Merger, Land -> Merge. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator
|
🛑 Automatic stack rebase aborted — diff mismatch The rebase of Please rebase manually and verify the changes are correct. |
kevinlnew
force-pushed
the
runway/vcs-extension
branch
from
ac42742 to
ce022df
Compare
kevinlnew
changed the title
| @@ -0,0 +1,58 @@ | |||
| // Copyright (c) 2025 Uber Technologies, Inc. | |||
Collaborator
There was a problem hiding this comment.
lets rename the file and folder as well
behinddwalls
approved these changes
Jun 23, 2026
Rename runway/extension/vcs/ to runway/extension/merger/ per review feedback. Package, file, and mock names updated accordingly. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Define the pluggable VCS interface with CheckMergeability (read-only,
request-level) and Land (mutating, batch-level) methods. Land returns
[]Outcome so the controller owns Result assembly. Includes generated
mock and a noop implementation for wiring and tests.
Co-Authored-By: Claude Opus 4.6 (1M context) noreply@anthropic.com
Test Plan
Issues
Stack