Skip to content

fix: prefer valkey_version over redis_version for Valkey server (#573) #574

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
xuxiaowei-com-cn wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: prefer valkey_version over redis_version for Valkey server (#573) #574

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d81983
fix: prefer valkey_version over redis_version for Valkey server (#573)
xuxiaowei-com-cn Jun 26, 2026
375c87a
refactor: separate Valkey and Redis version display in server status
xuxiaowei-com-cn Jun 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion backend/services/browser_service.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -229,7 +229,11 @@ func (b *browserService) OpenConnection(name string) (resp types.JSResp) {
if res, err := client.Info(ctx, "server").Result(); err == nil || errors.Is(err, redis.Nil) {
info := b.parseInfo(res)
serverInfo := maputil.Get(info, "Server", map[string]string{})
version = maputil.Get(serverInfo, "redis_version", "1.0.0")
// Prefer valkey_version if present, fallback to redis_version
version = maputil.Get(serverInfo, "valkey_version", "")
if version == "" {
version = maputil.Get(serverInfo, "redis_version", "1.0.0")
}
}

resp.Success = true
Expand Down
12 changes: 11 additions & 1 deletion frontend/src/components/content_value/ContentServerStatus.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -250,6 +250,10 @@ onUnmounted(() => {
stopAutoRefresh()
})

const valkeyVersion = computed(() => {
return get(serverInfo.value, 'Server.valkey_version', '')
})

const redisVersion = computed(() => {
return get(serverInfo.value, 'Server.redis_version', '')
})
Expand Down Expand Up @@ -595,7 +599,13 @@ const clientTableColumns = computed(() => {
<template #header>
<n-space :wrap-item="false" align="center" inline size="small">
{{ props.server }}
<n-tooltip v-if="redisVersion">
<n-tooltip v-if="valkeyVersion">
Valkey Version
<template #trigger>
<n-tag size="small" type="primary">v{{ valkeyVersion }}</n-tag>
</template>
</n-tooltip>
<n-tooltip v-else-if="redisVersion">
Redis Version
<template #trigger>
<n-tag size="small" type="primary">v{{ redisVersion }}</n-tag>
Expand Down