Skip to content

topology2: fix HDMI link IDs for sof-lnl-rt713-l0-rt1318-l1#10958

Open
likewhatevs wants to merge 1 commit into
thesofproject:mainfrom
likewhatevs:topology2-lnl-rt713-rt1318-hdmi-be-id
Open

topology2: fix HDMI link IDs for sof-lnl-rt713-l0-rt1318-l1#10958
likewhatevs wants to merge 1 commit into
thesofproject:mainfrom
likewhatevs:topology2-lnl-rt713-rt1318-hdmi-be-id

Conversation

@likewhatevs

Copy link
Copy Markdown

Hi, I disabled my mic in my bios (lenovo lunar lake laptop) and my speaker stopped working. This PR fixed it.

I don't quite follow the fix but AI says it's the following:

This topology has no DMIC backend, but inherits the default HDMI backend-link IDs of 5/6/7 from hdmi-default.conf. Those defaults assume a DMIC link occupies ID 4, so they start HDMI at 5.

The sof_sdw machine driver assigns backend-link IDs compactly. For this board the SoundWire jack and rt1318 amplifier links take IDs 0-3, and with no DMIC the iDisp links follow at 4/5/6. The topology's iDisp1 at ID 5 then matches no card link and the probe fails:

ASoC: physical link iDisp1 (id 5) not exist
error: failed to load DSP topology -22
sof_sdw: ASoC: failed to instantiate card -22

so the whole card, including speaker playback, is lost.

Set HDMI1_ID/HDMI2_ID/HDMI3_ID to 4/5/6 to match the IDs the driver creates for the no-DMIC case. This mirrors the -2ch variant, which adds two DMIC links at IDs 4/5 and correspondingly places HDMI at 6/7/8.

This topology has no DMIC backend, but inherits the default HDMI
backend-link IDs of 5/6/7 from hdmi-default.conf. Those defaults assume
a DMIC link occupies ID 4, so they start HDMI at 5.

The sof_sdw machine driver assigns backend-link IDs compactly. For this
board the SoundWire jack and rt1318 amplifier links take IDs 0-3, and
with no DMIC the iDisp links follow at 4/5/6. The topology's iDisp1 at
ID 5 then matches no card link and the probe fails:

  ASoC: physical link iDisp1 (id 5) not exist
  error: failed to load DSP topology -22
  sof_sdw: ASoC: failed to instantiate card -22

so the whole card, including speaker playback, is lost.

Set HDMI1_ID/HDMI2_ID/HDMI3_ID to 4/5/6 to match the IDs the driver
creates for the no-DMIC case. This mirrors the -2ch variant, which adds
two DMIC links at IDs 4/5 and correspondingly places HDMI at 6/7/8.

Signed-off-by: Pat Somaru <patso@likewhatevs.io>
Copilot AI review requested due to automatic review settings June 25, 2026 15:26
@sofci

sofci commented Jun 25, 2026

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

reply test this please to run this test once

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the topology2 build target for sof-lnl-rt713-l0-rt1318-l1 (Lunar Lake) to override HDMI backend-link IDs so they match the compact ID assignment used by the sof_sdw machine driver when no DMIC links are present. This prevents topology load failure (and therefore loss of the entire card, including speaker playback) in the no-DMIC case described in the PR.

Changes:

  • Override HDMI1_ID/HDMI2_ID/HDMI3_ID to 4/5/6 for sof-lnl-rt713-l0-rt1318-l1 in the ace2 production target list.
  • Align the non--2ch variant’s HDMI link IDs with the existing -2ch variant’s ID spacing behavior (which already accounts for DMIC links and places HDMI at 6/7/8).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants