Add Standalone Nexus Operation links#2932
Open
Quinn-With-Two-Ns wants to merge 4 commits into
Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 1 potential issue.
Reviewed by Cursor Bugbot for commit 487b9df. Configure here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

What was changed
Add Standalone nexus operation links
Why?
So SANO has nice links in the UI
Checklist
Closes
How was this tested:
Note
Medium Risk
Changes how Nexus and workflow RPCs attach links (including completion callbacks), which affects UI correlation; behavior is well-tested but mistakes could drop or mis-route links across SANO, workflows, and signal-with-start.
Overview
Adds bidirectional link plumbing for standalone Nexus operations (SANO): the SDK now converts and forwards
Link.NexusOperationalongside existingLink.WorkflowEventlinks through the Nexus handler path.LinkConvertergainsnexusOperationToNexusLink/nexusLinkToNexusOperation(usingtemporal:///…/nexus-operations/…/detailsURLs), pluslinkToNexusLinkandnexusLinkToLinkdispatchers.NexusTaskHandlerImpl,InternalUtils(Nexus-bound workflow start), andNexusStartWorkflowHelperare switched to these APIs so inbound SANO links attach to handler RPCs (e.g. signal-with-start) and response workflow-event links round-trip onStartOperationResponse.Integration tests cover SANO ↔ backing-workflow links and SANO-triggered signal-with-start back/forward links (external server only). Unit coverage for Nexus operation URL encoding/parsing is in
LinkConverterTest.Reviewed by Cursor Bugbot for commit 52c8fe6. Bugbot is set up for automated code reviews on this repo. Configure here.