Add WorkflowCheck Gradle plugin module#2931
Open
robzienert wants to merge 2 commits into
Open
Conversation
e5a9fec to
dcff0f8
Compare
dcff0f8 to
b426996
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
temporal-workflowcheck-gradle-pluginmoduleio.temporal.workflowcheckio.temporal:temporal-sdkversion fromruntimeClasspath, resolves the matchingio.temporal:temporal-workflowcheckanalyzer, and registers aworkflowCheckverification task.workflowCheckinto the Gradlechecklifecycle.Why?
temporal-workflowcheckis useful for catching non-deterministic calls in Workflow implementations, but Gradle users currently need to wire the analyzer themselves. This module provides a first-party Gradle integration that automatically uses the analyzer version matching the Temporal Java SDK on the consuming project's classpath.Breaking changes?
No.
Server PR
No server changes required.
Testing
We've been using this across many different project types within Netflix for a few months and have verified that this approach even for projects with massive classpaths.
./gradlew --no-daemon :temporal-workflowcheck-gradle-plugin:test./gradlew --no-daemon :temporal-workflowcheck-gradle-plugin:spotlessCheck