feat(validation): allow validation failures with messages#2196
Open
xHeaven wants to merge 1 commit into
Open
Conversation
| use Tempest\Validation\HasErrorMessage; | ||
| use Tempest\Validation\Rule; | ||
|
|
||
| #[Attribute] |
Contributor
There was a problem hiding this comment.
Would it make sense to make this not usable for validation (no attribute)? And perhaps using @internal or something?
Another tought: would an inline anonymous class fit here?
(Im assuming this is to not be "public")
Member
Author
There was a problem hiding this comment.
Maybe it's better now? I wouldn't use an anonymous class - validation failures can be flashed into the session, and they should remain properly serializable.
xHeaven
force-pushed
the
fix/validation-failed-messages
branch
from
b1f21e4 to
163ed0d
Compare
innocenzi
approved these changes
Jun 27, 2026
innocenzi
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2194