refactor: 학기 ID 상수 제거#588
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (8)
💤 Files with no reviewable changes (2)
Walkthrough
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0b8bf4f083
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| const termId = Number(process.env.NEXT_PUBLIC_UNIVERSITY_TERM_ID); | ||
|
|
||
| return Number.isInteger(termId) && termId > 0 ? termId : DEFAULT_UNIVERSITY_TERM_ID; | ||
| return Number.isInteger(termId) && termId > 0 ? termId : undefined; |
There was a problem hiding this comment.
Keep default-term searches scoped without env vars
In deployments following the documented env setup (.env.guide.md production variables and apps/web/.env.production do not define NEXT_PUBLIC_UNIVERSITY_TERM_ID), this now returns undefined; ApplyPageContent passes useDefaultTermId: true before loading selectable universities, so the search request is sent without any termId instead of the previous fallback 13. That lets the application flow load choices outside the current term whenever the API does not add the same default, so either keep a positive fallback or require/inject the term env before removing it.
Useful? React with 👍 / 👎.
작업 내용
학기 ID 상수를 제거합니다.
특이 사항
리뷰 요구사항 (선택)