Skip to content

refactor: 학기 ID 상수 제거#588

Merged
whqtker merged 1 commit into
mainfrom
refactor/remove-term-id-constant
Jun 27, 2026
Merged

refactor: 학기 ID 상수 제거#588
whqtker merged 1 commit into
mainfrom
refactor/remove-term-id-constant

Conversation

@whqtker

@whqtker whqtker commented Jun 27, 2026

Copy link
Copy Markdown
Member

작업 내용

학기 ID 상수를 제거합니다.

특이 사항

리뷰 요구사항 (선택)

@whqtker whqtker self-assigned this Jun 27, 2026
@vercel

vercel Bot commented Jun 27, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
solid-connect-university-web Ready Ready Preview, Comment Jun 27, 2026 7:12am
solid-connection-web Ready Ready Preview, Comment Jun 27, 2026 7:12am
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
solid-connect-web-admin Skipped Skipped Jun 27, 2026 7:12am

@github-actions github-actions Bot added the web label Jun 27, 2026
@coderabbitai

coderabbitai Bot commented Jun 27, 2026

Copy link
Copy Markdown

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro

Run ID: c02cfbc8-7aa3-4e81-b197-bc7c0e499625

📥 Commits

Reviewing files that changed from the base of the PR and between 3071e1f and 0b8bf4f.

📒 Files selected for processing (8)
  • apps/university-web/src/apis/universities/api.ts
  • apps/university-web/src/apis/universities/server/getSearchUniversitiesByFilter.ts
  • apps/university-web/src/apis/universities/server/getSearchUniversitiesByText.ts
  • apps/university-web/src/constants/university.ts
  • apps/web/src/apis/universities/api.ts
  • apps/web/src/apis/universities/server/getSearchUniversitiesByFilter.ts
  • apps/web/src/apis/universities/server/getSearchUniversitiesByText.ts
  • apps/web/src/constants/university.ts
💤 Files with no reviewable changes (2)
  • apps/web/src/constants/university.ts
  • apps/university-web/src/constants/university.ts

Walkthrough

  1. 기본 학기 ID 폴백 제거
    • 두 앱에서 DEFAULT_UNIVERSITY_TERM_ID가 삭제되고, 유효하지 않은 환경값은 undefined를 반환하도록 바뀌었습니다.
  2. 검색 쿼리 변경
    • 대학 검색 필터와 텍스트 요청에서 termId는 값이 있을 때만 URLSearchParams에 추가됩니다.
  3. 상수 정리
    • 학기 ID 관련 공용 상수 참조가 제거되었습니다.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Suggested reviewers

  • wibaek
  • enunsnv
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed 변경의 핵심인 학기 ID 상수 제거를 정확히 요약합니다.
Description check ✅ Passed 작업 내용과 주의 섹션은 갖췄고 변경 목적도 전달되지만, 관련 이슈 번호는 비어 있습니다.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch refactor/remove-term-id-constant

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 0b8bf4f083

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

const termId = Number(process.env.NEXT_PUBLIC_UNIVERSITY_TERM_ID);

return Number.isInteger(termId) && termId > 0 ? termId : DEFAULT_UNIVERSITY_TERM_ID;
return Number.isInteger(termId) && termId > 0 ? termId : undefined;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Keep default-term searches scoped without env vars

In deployments following the documented env setup (.env.guide.md production variables and apps/web/.env.production do not define NEXT_PUBLIC_UNIVERSITY_TERM_ID), this now returns undefined; ApplyPageContent passes useDefaultTermId: true before loading selectable universities, so the search request is sent without any termId instead of the previous fallback 13. That lets the application flow load choices outside the current term whenever the API does not add the same default, so either keep a positive fallback or require/inject the term env before removing it.

Useful? React with 👍 / 👎.

@whqtker whqtker merged commit 315ce52 into main Jun 27, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant