fix(cli): trim leading slash in download_prefix to prevent Path::join treating relative path as absolute#247
Merged
Conversation
… treating relative path as absolute
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
rc cp -rincorrectly writing files to the system root (/) when the source prefix lacks a trailing slash (e.g.,alias/bucket/dirinstead ofalias/bucket/dir/).Related: #244
What Changed
download_prefixincrates/cli/src/commands/cp.rs:.trim_start_matches('/')to the relative key computed bystrip_prefix.Path::joinfrom interpreting it as an absolute path and discarding the destination directory.Why
When
src.key = "dir"anditem.key = "dir/file",strip_prefixreturns"/file"(leading slash).Path::jointreats any argument starting with/as an absolute path, ignoring the user-specified destination and writing files to the system root. This violates user expectations and is inconsistent with other S3 clients likemcli.Impact
rc cp -r alias/bucket/dir ./without needing to append a trailing slash./remains unchanged.Verification
cargo fmt --all --check(pass)cargo clippy --workspace -- -D warnings(pass)cargo test --workspace(pass)