chore: update testing configuration and add type hints support#518
Open
hydrogen7797 wants to merge 6 commits into
Open
chore: update testing configuration and add type hints support#518hydrogen7797 wants to merge 6 commits into
hydrogen7797 wants to merge 6 commits into
Conversation
|
Capy auto-review is paused for this organization because the usage-cycle auto-review limit has been reached. Increase the limit or turn it off in billing settings to resume automatic reviews. |
…d modify coroutine check condition
There was a problem hiding this comment.
Pull request overview
This PR updates the project’s testing configuration (warnings/coverage settings and test dependencies) and adds PEP 561 type-hint marker support by introducing py.typed into the distributed package data.
Changes:
- Replace deprecated
asyncio.iscoroutinefunctionusage in tests withinspect.iscoroutinefunction. - Remove
asynctestfrom test extras and adjust pytest configuration (coverage config location + warning filtering). - Add
runpod/py.typedand include it in setuptools package data for type-hint discovery.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
tests/test_serverless/test_modules/test_fitness/test_system_checks.py |
Uses inspect.iscoroutinefunction to avoid deprecated asyncio API. |
setup.py |
Removes asynctest from test extras. |
runpod/py.typed |
Adds the PEP 561 marker file to indicate the package ships type information. |
pytest.ini |
Switches coverage config to pyproject.toml and updates warning handling via -W options. |
pyproject.toml |
Includes py.typed in package data and updates the test dependency group. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| # only warn. Don't fail the suite on them until the deps update. | ||
| ignore:'asyncio\.get_event_loop_policy' is deprecated:DeprecationWarning | ||
| ignore:'asyncio\.iscoroutinefunction' is deprecated:DeprecationWarning | ||
| addopts = --durations=10 --cov-config=pyproject.toml --timeout=120 --timeout_method=thread --cov=runpod --cov-report=xml --cov-report=term-missing --cov-fail-under=90 -W error -W ignore::DeprecationWarning:backoff._decorator -p no:cacheprovider -p no:unraisableexception |
Comment on lines
51
to
55
| [tool.setuptools.package-data] | ||
| runpod = [ | ||
| "py.typed", | ||
| "serverless/binaries/gpu_test", | ||
| "serverless/binaries/README.md", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.