Skip to content

Remove excess error from config#4151

Open
Earlopain wants to merge 1 commit into
ruby:mainfrom
Earlopain:remove-excess-error
Open

Remove excess error from config#4151
Earlopain wants to merge 1 commit into
ruby:mainfrom
Earlopain:remove-excess-error

Conversation

@Earlopain

Copy link
Copy Markdown
Collaborator

Seems to have been left unused since 8266572

Now this causes build failures in windows CI, not sure why only now:

src/diagnostic.c:781:46: error: array subscript 329 is above array bounds of 'const pm_diagnostic_data_t[329]' [-Werror=array-bounds=]
compiling build/shared/integer.o
  781 |     const char *message = diagnostic_messages[diag_id].message;
compiling build/shared/json.o
      |                           ~~~~~~~~~~~~~~~~~~~^~~~~~~~~
compiling build/shared/line_offset_list.o
src/diagnostic.c: In function 'pm_diagnostic_list_append':
src/diagnostic.c:97:35: note: while referencing 'diagnostic_messages'
   97 | static const pm_diagnostic_data_t diagnostic_messages[PM_DIAGNOSTIC_ID_MAX] = {
      |                                   ^~~~~~~~~~~~~~~~~~~

@Earlopain Earlopain force-pushed the remove-excess-error branch from 983419a to b835b96 Compare June 29, 2026 17:45
`ARGUMENT_BLOCK_FORWARDING` seems to have been left unused since ruby@8266572
The other I didn't find (possible I missed it)
@Earlopain Earlopain force-pushed the remove-excess-error branch from b835b96 to ae8cba3 Compare June 29, 2026 18:01
@Earlopain

Copy link
Copy Markdown
Collaborator Author

Hm, I thought it would be related to this, but I guess not

@Earlopain Earlopain marked this pull request as ready for review June 29, 2026 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant