Download React Native artifacts from the proxy cache server first#57325
Draft
coado wants to merge 4 commits into
Draft
Download React Native artifacts from the proxy cache server first#57325coado wants to merge 4 commits into
coado wants to merge 4 commits into
Conversation
meta-cla
Bot
added
the
CLA Signed
facebook-github-tools
Bot
added
p: Software Mansion
cortinico
reviewed
Jun 24, 2026
cortinico
left a comment
cortinico
left a comment
Contributor
There was a problem hiding this comment.
Great stuff 👍 love the direction
| "commander": "^12.0.0", | ||
| "flow-enums-runtime": "^0.0.6", | ||
| "hermes-compiler": "0.0.0", | ||
| "hermes-compiler": "250829098.0.14", |
| repo.content { it.excludeGroup("org.webkit") } | ||
| } | ||
| } | ||
| if (!hasProperty(INTERNAL_REACT_NATIVE_MAVEN_LOCAL_REPO)) { |
Contributor
There was a problem hiding this comment.
I think we probably want to add a kill-switch that disables this entirely, like a react.internal.enableReactNativeRepoMirror=false gradle property (naming up for debate).
We would need the same for iOS
|
|
||
| class ReactNativeCoreUtils | ||
| MAVEN_CENTRAL_REPOSITORY = "https://repo1.maven.org/maven2" | ||
| REACT_NATIVE_MAVEN_CACHE_REPOSITORY = "https://rnmaven.swmtest.xyz" |
Contributor
There was a problem hiding this comment.
This returns 404. Can we have a landing page? :)
Contributor
There was a problem hiding this comment.
this is also really nit 💅
| } | ||
| } | ||
| if (!hasProperty(INTERNAL_REACT_NATIVE_MAVEN_LOCAL_REPO)) { | ||
| mavenRepoFromUrl(REACT_NATIVE_MAVEN_CACHE_URL) { repo -> |
Contributor
There was a problem hiding this comment.
Let's add a comment mentioning that this is added "first" intentionally
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
This PR adds pull-through cache support for React Native Maven artifacts by trying
https://rnmaven.swmtest.xyz/before Maven Central for release artifacts.mavenCentral()scoped to React Native groups viaincludeGroupByRegex.https://repo1.maven.org/maven2.ENTERPRISE_REPOSITORYbehavior as an explicit single custom repository override.Changelog:
[GENERAL][CHANGED] - Add React Native Maven pull-through cache fallback for prebuilt artifacts.
Test Plan:
Run:
The logs confirm that React Native artifacts are cached and pulled from the proxy:
Added gradle plugin tests which can be run with: