Add Fantom benchmark for ViewProps cloneProps (#57324)#57324
Closed
javache wants to merge 1 commit into
Closed
Conversation
meta-cla
Bot
added
the
CLA Signed
|
@javache has exported this pull request. If you are a Meta employee, you can view the originating Diff in D109563268. |
Summary: Adds `ViewProps-benchmark-itest.js` covering three scenarios that exercise the C++ Props construction path: 1. Mount N views with a full prop bag (initial Props construction). 2. Re-render N views with a full prop swap (cloneProps, every prop changes). 3. Re-render N views with a single-prop delta (cloneProps, hot path for typical UI updates). `fantom_flags enableCppPropsIteratorSetter:*` matrix-expands the suite so each scenario runs once with the classic per-field parse and once with the iterator-setter path. This establishes a baseline for upcoming changes that simplify the per-class `flag ? sourceProps.X : convertRawProp(...)` ternaries into two distinct constructors and that skip the now-unused `RawPropsParser::parse()` in the iterator-setter branch. Changelog: [Internal] Differential Revision: D109563268
meta-codesync
Bot
changed the title
javache
force-pushed
the
export-D109563268
branch
from
1759faf to
be15138
Compare
|
This pull request has been merged in a224e03. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Adds
ViewProps-benchmark-itest.jscovering three scenarios that exercise the C++ Props construction path:fantom_flags enableCppPropsIteratorSetter:*matrix-expands the suite so each scenario runs once with the classic per-field parse and once with the iterator-setter path. This establishes a baseline for upcoming changes that simplify the per-classflag ? sourceProps.X : convertRawProp(...)ternaries into two distinct constructors and that skip the now-unusedRawPropsParser::parse()in the iterator-setter branch.Changelog:
[Internal]
Differential Revision: D109563268