Warn instead of raising when the connection pool is smaller than the thread pool#752
Closed
ajaynomics wants to merge 1 commit into
Closed
Warn instead of raising when the connection pool is smaller than the thread pool#752ajaynomics wants to merge 1 commit into
ajaynomics wants to merge 1 commit into
Conversation
…thread pool Solid Queue refused to boot when the Active Record connection pool was smaller than the worker thread pool. This blocked legitimate setups, such as I/O-bound queues that run many threads against a deliberately small pool. Per the discussion in rails#736, downgrade the check from a validation error to a SolidQueue.logger warning emitted once on the boot path in Supervisor.start, so undersized configurations boot while still surfacing the advisory. valid? stays purely about whether we can boot. Closes rails#736
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solid Queue currently refuses to boot when the Active Record connection pool is smaller than the worker thread pool, raising a configuration validation error. This blocks legitimate setups such as I/O-bound queues that run many threads against a deliberately small pool.
This downgrades the check from a validation error to a
SolidQueue.loggerwarning. The warning is emitted once on the boot path inSupervisor.start, after the configuration is confirmed valid, so undersized configurations boot and run while still surfacing the advisory.Configuration#valid?stays purely about whether we can boot.The original message wording is retained, just at
warnlevel.Closes #736