Split linting from main workflow#144
Conversation
|
Posted a PR fixing the failure cause: python/cpython#151343 |
Thanks, merged! |
| - run: git add . | ||
| - run: git commit -m "$(python manage_translation.py generate_commit_msg)" | ||
| if: env.SIGNIFICANT_CHANGES | ||
| - name: Push commit |
There was a problem hiding this comment.
This shouldn't run on PRs IMO. This causes issues like https://github.com/python/python-docs-pl/actions/runs/27407678283/job/81000784306?pr=144.
| - uses: astral-sh/setup-uv@08807647e7069bb48b6ef5acd8ec9567f424441b # v8.1.0 | ||
| - uses: actions/download-artifact@3e5f45b2cfb9172054b4087a40e8e0b5a5461e7c # v8.0.1 | ||
| with: | ||
| name: build-${{ matrix.version }}-epub |
There was a problem hiding this comment.
This will need read permissions (which we don't give above with permissions: {}), and passed a run-id, see https://github.com/actions/download-artifact#download-artifacts-from-other-workflow-runs-or-repositories.
There was a problem hiding this comment.
added actions: read for this job
| on: # zizmor: ignore[dangerous-triggers] | ||
| workflow_run: | ||
| workflows: [update and build] | ||
| types: [completed] |
There was a problem hiding this comment.
Does this include failures, lint-epub will need gating for that as otherwise it'll scream when it tries to download the artefact.
There was a problem hiding this comment.
added this, thank you for thorough review!
…t correct permissions, add run-id and auth to download artifact job
|
@copilot resolve the merge conflicts in this pull request |
|
Oh no, sorry this slipped my mind. I'll review later today. |
|
The following commit authors need to sign the Contributor License Agreement: |
Resolved in b1e0efc. The conflicts were in the auto-generated badge stats sections of both README files — took the newer translation percentages from |
| - name: Push commit | ||
| uses: ad-m/github-push-action@881a6320fdb16eb5318c5054f31c218aec2b324c # v1.3.0 | ||
| if: env.SIGNIFICANT_CHANGES | ||
| if: env.SIGNIFICANT_CHANGES && (github.event.workflow_run.head_branch == github.event.repository.default_branch) |
There was a problem hiding this comment.
There's no workflow_run trigger?
|
|
||
| jobs: | ||
| lint: | ||
| if: github.event.workflow_run.conclusion == 'success' |
There was a problem hiding this comment.
| if: github.event.workflow_run.conclusion == 'success' |
By splitting workflows we get a better, gradual feedback and state of things expression.
Building without strict mode, we can add back strict mode as a separate workflow (or as part of linting?) in the future.
Updated READMEs with new workflow links. Extra changes: dropped translations mailing list and added a link to Sphinx translation.
Unable to test workflow run trigger before the PR is merged into main.
To do:
-Wflag); corresponding job called withmake dist-pdfdoesn't fail: https://github.com/m-aciek/python-docs-offline/actions/runs/27127952047/job/80061499030