gh-152099: Raise SendfileNotAvailableError for fallback-only transports#152223
Open
zainnadeem786 wants to merge 1 commit into
Open
gh-152099: Raise SendfileNotAvailableError for fallback-only transports#152223zainnadeem786 wants to merge 1 commit into
zainnadeem786 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR makes
BaseEventLoop.sendfile()consistently raiseasyncio.SendfileNotAvailableErrorwhen native sendfile cannot be used for fallback-capable transports (such as SSL/TLS) andfallback=False.Currently, native sendfile failures on
_SendfileMode.TRY_NATIVEtransports already raiseSendfileNotAvailableError, while_SendfileMode.FALLBACKtransports raise a genericRuntimeError. This results in inconsistent exception behavior for the same practical condition: native sendfile is unavailable and fallback has been disabled.The change updates only the fallback-only transport path. Unsupported transports and closing transports continue to raise
RuntimeErrorunchanged.Changes
SendfileNotAvailableErrorinstead ofRuntimeErrorfor_SendfileMode.FALLBACKwhenfallback=False.Validation
Executed:
All focused tests passed.
Compatibility
SendfileNotAvailableErrorsubclassesRuntimeError, so existing code catchingRuntimeErrorcontinues to work while allowing applications to reliably detect native sendfile unavailability.Closes gh-152099.