Skip to content

Don't define class-scoped fixtures as instance methods #1563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjwatson wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Don't define class-scoped fixtures as instance methods #1563

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions tests/opc/test_phys_pkg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,8 @@ def pkg_file_(self, request):
return loose_mock(request)

@pytest.fixture(scope="class")
def dir_reader(self):
@classmethod
def dir_reader(cls):
return _DirPkgReader(dir_pkg_path)


Expand Down Expand Up @@ -115,7 +116,8 @@ def it_returns_none_when_part_has_no_rels_xml(self, phys_reader):
# fixtures ---------------------------------------------

@pytest.fixture(scope="class")
def phys_reader(self):
@classmethod
def phys_reader(cls):
phys_reader = _ZipPkgReader(zip_pkg_path)
yield phys_reader
phys_reader.close()
Expand Down