Skip to content

feat: Implement github_create_pr in write_tools.py + test#5

Merged
mabry1985 merged 1 commit into
mainfrom
feat/github-plugin-1ez.6
Jun 21, 2026
Merged

feat: Implement github_create_pr in write_tools.py + test#5
mabry1985 merged 1 commit into
mainfrom
feat/github-plugin-1ez.6

Conversation

@mabry1985

Copy link
Copy Markdown
Contributor

The gate says only one thing failed: tests/test_write_tools.py needs reformatting. Let me look at the current state of both files.The gate says only one thing failed: tests/test_write_tools.py needs reformatting. Let me look at the current state of both files.The code is complete and correct. The only failure is ruff format wanting to reformat tests/test_write_tools.py. Let me check the formatter config to find what it would change.Line-length is 120. The multi-line ainvoke call at lines 130-133 collapses to a single line (116 chars, under 120), which is exactly what ruff format would do. Let me fix it.Done. The implementation in write_tools.py was already correct — github_create_pr validates with bad_repo(), builds the full args list with --base always present (defaulting to "main"), runs via run_gh, checks errors with check_gh_error, and returns out.strip(). The tests cover URL return, base-defaults-to-main, base override, bad repo, and gh failure.

The only gate failure was formatting: the previous attempt wrapped the ainvoke call across three lines, but it fits in 116 chars (under the 120 limit), so ruff format wanted it on one line. Collapsed it — that resolves the Would reformat failure with no change to behavior.

@protoquinn

protoquinn Bot commented Jun 21, 2026

Copy link
Copy Markdown

👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow.

@protoquinn protoquinn Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QA Audit — PR #5 | feat: Implement github_create_pr in write_tools.py + test

VERDICT: WARN (non-blocking — CI still queued)


CI Status

  • test: queued

Diff Review

  • write_tools.py: Replaces the stub with real implementation following existing patterns — validates repo via bad_repo(), builds full args with --base always present (defaulting to "main"), runs gh, checks errors with check_gh_error, returns out.strip(). Consistent with github_create_issue and github_comment.
  • tests/test_write_tools.py: 5 new async tests covering success URL return, base default, base override, bad repo short-circuit, and gh failure. Mirror existing test patterns.

Observations

  • LOW: CI (test) still queued — re-review needed once terminal for a formal PASS/FAIL.

— Quinn, QA Engineer

@protoquinn

protoquinn Bot commented Jun 21, 2026

Copy link
Copy Markdown

Submitted COMMENT review on #5.

@protoquinn protoquinn Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI terminal-green, no blockers on prior review — auto-approving on green (#748).

@mabry1985 mabry1985 merged commit cf47db1 into main Jun 21, 2026
1 check passed
@mabry1985 mabry1985 deleted the feat/github-plugin-1ez.6 branch June 21, 2026 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant