feat: split surfaces — read-only board + util-bar/⌘K file-an-issue#10
Merged
Conversation
Reshape the console surfaces per the intended UX: the board is a VIEWER and
filing moves to the util bar + the command palette.
- view.py: PAGE is now the READ-ONLY board (Issues/PRs tabs + repo picker + state
filter; the New-issue form is gone). New NEW_ISSUE_PAGE = a compact file-an-issue
form (title/kind/repo/body → the gate-checked POST /issue).
- api.py: the view router also serves /new-issue.
- manifest: two views — the board (`placement: right` + `palette: inline` ⌘K morph)
and `github-new-issue` (a util-bar widget via `utility: {info}` AND a distinct ⌘K
page via `palette: {path}`). So Issues/PRs are a quick view (dock + ⌘K) and posting
an issue is in the util bar + ⌘K — not in the board.
- tests: board-is-read-only (no POST /issue), /new-issue served, both pages hit the
gated routes, and the manifest declares both views with the right utility/palette.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
👀 Quinn is reviewing — verdict (PASS / WARN / FAIL) + findings to follow. |
![protoquinn[bot]](https://avatars.githubusercontent.com/in/3282126?s=60&v=4){kind=small}
There was a problem hiding this comment.
QA Audit — PR #10 | feat: split surfaces — read-only board + util-bar/⌘K file-an-issue
VERDICT: WARN
CI Status
- test: in_progress ⏳
Diff Review
api.py: Clean — adds one GET/new-issueroute, importsNEW_ISSUE_PAGE. No regression risk.protoagent.plugin.yaml: Two views declared correctly — board w/palette: inline, new-issue w/utilitypill +palette: { path }. Manifest structure validates in tests.tests/test_board_view.py: 4 new/expanded tests. Read-only assertion uses exact-match string (closing quote) to avoid substring collisions — well-considered.view.py+PROTO.md: Docs and split PAGE/NEW_ISSUE_PAGE. Truncated diff means I can't inspect the full NEW_ISSUE_PAGE HTML — see Gaps.
Observations
- GAP:
NEW_ISSUE_PAGEHTML body truncated in diff (374-line cutoff). Test confirms gated endpoint + DS kit presence, but form markup not fully reviewed. Low risk given test coverage. - LOW:
clawpatch_reviewunavailable forprotoLabsAI/github-plugin— structural review skipped. - NOTE: CI
teststill in_progress. Re-review will land formal PASS/FAIL once checks are terminal. No blocking issues found in diff — expect PASS if CI goes green.
— Quinn, QA Engineer
|
Submitted COMMENT review on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Reshapes the plugin's console surfaces to the intended UX: the board is a viewer; filing an issue moves to the util bar + the command palette.
/view) — Issues / Pull Requests tabs + repo picker + open/closed/all filter. Right dock and a ⌘K morph (palette: inline). The New-issue form is removed — it's a quick read./new-issue) — a compact form (title / kind / repo / body → the gate-checkedPOST /issue). Surfaced two ways via the manifest: a util-bar widget pill (utility: {info}, opens its dialog) and a distinct ⌘K palette page (palette: {path}).So: a quick look at Issues/PRs is in the dock + ⌘K; posting an issue is in the util bar + ⌘K — and the board stays read-only. All via the existing fork-safe iframe view seams (no core console edits).
Tests
test_board_view: board-is-read-only (noPOST /issue),/new-issueserved, both pages hit the gated routes, and the manifest declares both views with the rightutility/palette.ruff+pytest -q→ 81 passed.🤖 Generated with Claude Code