Add origin as query string to requests to plotlyServerURL#7854
Open
marthacryan wants to merge 2 commits into
Open
Add origin as query string to requests to plotlyServerURL#7854marthacryan wants to merge 2 commits into
marthacryan wants to merge 2 commits into
Conversation
emilykl
reviewed
Jun 19, 2026
Comment on lines
+218
to
+221
| var uploadUrl = serverURL + | ||
| (serverURL.indexOf('?') === -1 ? '?' : '&') + | ||
| 'origin=' + encodeURIComponent(window.location.origin); | ||
| var cloudWindow = window.open(uploadUrl, '_blank'); |
Contributor
There was a problem hiding this comment.
@marthacryan Is there any built-in JS utility for handling URL params that we could use here?
Contributor
There was a problem hiding this comment.
^ ah yeah that looks right, or the URL API more broadly. I think the most thorough logic would be:
- parse
serverURLinto its base URL plus params - add
origin: window.location.originto params dict - re-generate full URL with new params
I suppose we could also just strip URL parameters from serverURL entirely since we don't currently have a use for them... but that might not even be any simpler.
Contributor
Author
There was a problem hiding this comment.
@emilykl Good point! How does the updated code look?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For secure communication between tabs via postMessage (after clicking the "upload to cloud" button), we need to include the origin of the request as a query string.