Fix session memory leak on failed user save handler close#22440
Open
abolfazl-moeini wants to merge 1 commit into
Open
Fix session memory leak on failed user save handler close#22440abolfazl-moeini wants to merge 1 commit into
abolfazl-moeini wants to merge 1 commit into
Conversation
0acde11 was reverted in 3073948. That patch swapped EG(exception) around s_close() in php_session_abort() and did not cover close() returning false without parent::close(). php_session_abort() now tears down session state the same way php_rshutdown_session_globals() does. ps_close_user() closes the default save handler when mod_data is still allocated after the userland close callback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the memory leak reported in #21200 after #21200 was reverted in 3073948.
The reverted patch saved/restored
EG(exception)arounds_close()inphp_session_abort(). That changed exception behaviour and did not fixleaks when a
SessionHandlersubclassclose()returned false withoutcalling
parent::close().Changes:
php_session_abort()tears down session state likephp_rshutdown_session_globals()ps_close_user()closes the default save handler whenmod_datais still setTests (debug build leak detection):
ext/session/tests/session_abort_validateid_leak.phptext/session/tests/session_close_false_leak.phpt