Skip to content

Fix invalid YAML in an example#1145

Merged
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:example-fix
Jun 24, 2026
Merged

Fix invalid YAML in an example#1145
centosinfra-prod-github-app[bot] merged 1 commit into
packit:mainfrom
nforro:example-fix

Conversation

@nforro

@nforro nforro commented Jun 24, 2026

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: Nikola Forró <nforro@redhat.com>

@majamassarini majamassarini left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we wrap the numbers in double quotes also for the example below?

@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@nforro

nforro commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

Shouldn't we wrap the numbers in double quotes also for the example below?

That's valid YAML. The question is if we want to be consistent or if we want the example to demonstrate that some expressions can be used without quotes 🙂 WDYT?

@majamassarini

Copy link
Copy Markdown
Member

If it is valid then I am fine as it is.

@nforro nforro added the mergeit Merge via Zuul label Jun 24, 2026
@centosinfra-prod-github-app

Copy link
Copy Markdown
Contributor

@centosinfra-prod-github-app centosinfra-prod-github-app Bot merged commit c72515b into packit:main Jun 24, 2026
6 checks passed
@github-project-automation github-project-automation Bot moved this from New to Done in Packit pull requests Jun 24, 2026
@nforro nforro deleted the example-fix branch June 24, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mergeit Merge via Zuul

Projects

Development

Successfully merging this pull request may close these issues.

3 participants