chore(deps): bump asciidoctor from 3.0.4 to 4.0.0#5115
Conversation
DeepDiver1975
left a comment
There was a problem hiding this comment.
Asciidoctor 3.0.4 → 4.0.0 (Ruby gem) — MAJOR bump review
This bumps the Ruby asciidoctor gem one major version in the docs toolchain that powers the Antora/AsciiDoc rendering pipeline.
- Manifest/lockfile change only — no source/converter/extension code touched in this PR. ✅
- CI status:
Documentationbuild PASS,lintPASS — the full docs build succeeded against v4. ✅ mergeable: MERGEABLE(no conflicts).
Asciidoctor 4.0 is a major release: it drops support for older Ruby versions and carries breaking changes for custom converters/extensions and some default behaviors. The green Documentation job is a strong signal the build itself works against v4, but a green build does not fully prove the rendered output is unchanged (subtle rendering regressions — spacing, anchors, callouts, admonition styling — would not necessarily fail CI).
Verdict: looks good / no objections from the toolchain side, but recommend a human eyeball the rendered docs before merge. Because this is a major bump of the core rendering engine, I am not auto-merging it — a maintainer should confirm there are no rendering regressions in the built output, then merge. Changelog: n/a (this repo has no changelog convention).
🤖 Generated with Claude Code
Bumps [asciidoctor](https://github.com/asciidoctor/asciidoctor.js) from 3.0.4 to 4.0.0. - [Release notes](https://github.com/asciidoctor/asciidoctor.js/releases) - [Changelog](https://github.com/asciidoctor/asciidoctor.js/blob/main/CHANGELOG.adoc) - [Commits](asciidoctor/asciidoctor.js@v3.0.4...v4.0.0) --- updated-dependencies: - dependency-name: asciidoctor dependency-version: 4.0.0 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
12bf3f2 to
f8496e7
Compare
DeepDiver1975
left a comment
There was a problem hiding this comment.
Re-reviewed at head f8496e7 (new commits since last sweep).
What changed: still a pure manifest bump — only package.json + package-lock.json touched, moving asciidoctor ^3.0.4 → ^4.0.0 (with @asciidoctor/cli and the babel/glob/unxhr deps pruned, @asciidoctor/core 3.0.4 now resolved as a peer).
CI: green — Documentation and Lint PR title both SUCCESS.
Assessment: asciidoctor 4.0.0 is a major engine bump, and CI building cleanly does not by itself prove the rendered HTML is byte-for-byte equivalent across the whole docs set (heading anchors, callouts, admonition/table markup, kroki integration). Major-version rendering regressions are exactly the kind of thing a green build can hide.
Holding for human render verification before merge: please spot-check a built preview (especially admonitions, tables, source callouts, and kroki diagrams) against the current 3.x output. No changelog convention in this repo, so nothing required there.
🤖 Generated with Claude Code
Bumps asciidoctor from 3.0.4 to 4.0.0.
Release notes
Sourced from asciidoctor's releases.
... (truncated)
Changelog
Sourced from asciidoctor's changelog.
... (truncated)
Commits
c73c6974.0.0b918740fix(extensions): preserve directly-registered extensions across registry reuse1b7efdcdocs: document registry reuse behaviour and add tests0ac262bdocs(extensions): add@overloadsignatures to IncludeProcessorDsl#handlesb02ce92feat(cli): warn when extension does not export a register function81a909atest: add CJS extension support test and document ESM/CJS formatsb1bba08feat: add --extension CLI option and clarify --require contractd068c524.0.0-alpha.6505c48adocs(changelog): move admonition caption fix to unreleased sectione8e93bafix(core): store caption text in textlabel for delimited admonition blocksMaintainer changes
This version was pushed to npm by GitHub Actions, a new releaser for asciidoctor since your current version.