OSASINFRA-4373: Migrate to openshift-tests-extension (OTE), 4.14#275
OSASINFRA-4373: Migrate to openshift-tests-extension (OTE), 4.14#275danchild wants to merge 1 commit into
Conversation
openshift-ci-robot
added
the
jira/valid-reference
openshift-ci
Bot
added
the
do-not-merge/work-in-progress
|
Skipping CI for Draft Pull Request. |
|
@danchild: This pull request references OSASINFRA-4373 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.14.z" version, but no target version was set. DetailsIn response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
/assign @mandre |
openshift-ci
Bot
removed
the
do-not-merge/work-in-progress
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Mirror of PR openshift#260 for release-4.14 - Original commit message and fix by @mandre Add cmd/extension/main.go as a new OTE-based test extension binary alongside the existing openshift-tests entry point. This registers all openstack tests with the OTE framework, adds [OTP] annotations to all Describe blocks, and integrates the extension build into the Makefile and Containerfile. The OTE binary discovers 36 tests and does not pull in origin's monitor test framework, avoiding the duplicate test results seen with the old entry point. Workaround: Previous OTE migrations used a monorepo approach; however, that approach won't work for earlier openstack-test release versions. The openshift-tests entry point uses an outdated version of ginko whose API is imcompatible with the the openshift-test-ext framework. A seperate module is used to test OTE alongside the existing openshift-tests. The module has the same form as that taken in previous migrations (e.g. openshift#260). A `git mv` and changing line 25 on the Makefile is all that is needed to accomplish a unified structure across releases. Finally, the module tests-extension is not vendored, because it is a workaround and we don't want to include hundreds to thousands of objects that will eventually drop from the repo anyway. Signed-off-by: Dan Childers <dchilder@redhat.com>
|
@danchild: all tests passed! Full PR test history. Your PR dashboard. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
3 participants
Migrate to OTE using the ote-migration skill [1].
Add cmd/extension/main.go as a new OTE-based test extension binary
alongside the existing openshift-tests entry point. This registers
all openstack tests with the OTE framework, adds [OTP] annotations
to all Describe blocks, and integrates the extension build into the
Makefile and Containerfile.
The OTE binary discovers 36 tests and does not pull in origin's
monitor test framework, avoiding the duplicate test results seen
with the old entry point.
[1] https://github.com/openshift-eng/ai-helpers/tree/main/plugins/ote-migration
Previous OTE migrations used a monorepo approach; however, that
approach won't work for earlier openstack-test release versions.
The openshift-tests entry point uses an outdated version
of ginko whose API is imcompatible with the the openshift-test-ext
framework. A seperate module is used to test OTE alongside
the existing openshift-tests. The module has the same form as
that taken in previous migrations (e.g. #260). A git mv and
changing line 25 on the Makefile is all that is needed to accomplish a unified structure across releases. Finally,
the module tests-extension is not vendored, because it is a workaround and we don't want to include hundreds
to thousands of objects that will eventually drop from the repo anyway.