debugger: preserve probe failure attribution#64102
Closed
trivikr wants to merge 1 commit into
Closed
Conversation
Keep per-call CDP in-flight state available when recording inspector failures. This prevents an older overlapping CDP request from clearing the active probe evaluation state before a disconnect or target-exit failure is reported. Signed-off-by: Kamat, Trivikram <16024985+trivikr@users.noreply.github.com> Assisted-by: openai:gpt-5.5
Member
Author
|
Refs: #63632 (comment) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
parallel/test-debugger-probe-failure-process-exitcan be flaky when aprobe expression exits the target while
Debugger.evaluateOnCallFrameispending.
An older overlapping CDP request can clear the shared
inFlightstate beforethe probe evaluation failure is recorded. When that happens, the failure is
reported as if the probe never ran, leaving it in
pending, instead ofrecording the expected failed probe hit.
This PR keeps the CDP in-flight context local to each
callCdp()invocationand passes it explicitly into failure reporting. Also it clears
this.inFlightonly ifthe finishing call still owns the current in-flight state.
Refs: https://github.com/nodejs/reliability/issues?q=sort%3Aupdated-desc%20test-debugger-probe-failure-process-exit
Example
Assisted-by: openai:gpt-5.5