fix(editor): preserve leading newlines in plain text editor#8787
Open
omnizs38 wants to merge 1 commit into
Open
fix(editor): preserve leading newlines in plain text editor#8787omnizs38 wants to merge 1 commit into
omnizs38 wants to merge 1 commit into
Conversation
Signed-off-by: omnizs38 <omnizs@proton.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📝 Summary
This PR fixes an issue where the plain text editor stripped leading newlines and trailing whitespace on empty first lines of plain text documents.
When setting or updating the content of the plain text editor, the raw content is escaped and wrapped inside HTML
<pre>...</pre>tags. By standard HTML rules,DOMParserstrips a single leading newline character inside<pre>tags. Prepending a newline (\n) to<pre>content ensures thatDOMParserstrips only our prepended newline, leaving the document's original leading newlines and whitespace intact.This change also re-enables the previously skipped CommonMark plain text tests
97and117, which now pass successfully.🖼️ Screenshots
🚧 TODO
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)🤖 AI (if applicable)