fix(versions): preserve version encrypted version before rollback#61562
Open
leftybournes wants to merge 1 commit into
Open
fix(versions): preserve version encrypted version before rollback#61562leftybournes wants to merge 1 commit into
leftybournes wants to merge 1 commit into
Conversation
Signed-off-by: Kent Delante <kent@delante.me>
leftybournes
added
bug
3. to review
leftybournes
requested review from
Altahrim,
ArtificialOwl,
come-nc and
provokateurin
and removed request for
a team
| $versionCache->update( | ||
| $versionFileInfo->getId(), [ | ||
| 'encrypted' => $encryptedVersion, | ||
| 'encryptedVersion' => $encryptedVersion, |
Member
There was a problem hiding this comment.
encrypted should probably not get set or at least not to the version?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
While rolling back, the created file version's encrypted version is set to 1 when it is actually higher, causing it to appear corrupted when restoring to it. This preserves the encrypted version for the created file version to prevent "corruption" from happening.
Checklist
3. to review, feature component)stable32)AI (if applicable)