Added net461 compilation target#978
Conversation
This was necessary to prevent .net framework projects to restore the net45 version of the package (which lacks support for exporting data from async enumerables among other things) instead of the "intended" netstandard2.0
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates MiniExcel's target frameworks to include net461, refactors preprocessor directives to use #if !NET45, optimizes image format detection in ImageHelper.cs, and rewrites the NuGet README. However, several issues were identified: non-existent package versions for Microsoft.SourceLink.GitHub and Microsoft.Bcl.AsyncInterfaces will break the build, shortened TIFF magic bytes in ImageHelper.cs may cause false positives on older frameworks, and using a package reference for System.IO.Compression on .NET Framework targets could lead to assembly conflicts. Additionally, a syntax error and a typo were found in the README examples.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
michelebastione
merged commit e1c6869
into
mini-software:v1.x-maintenance
1 participant
This change was implemented to prevent .NET Framework projects to restore through nuget the net45 version of the package (which lacks support for exporting data from async enumerables among other things) instead of the "intended" netstandard2.0. The readme for the NuGet page has also been updated.
fixes #974