[WTF-2695]: Escape package name before using in spawn#186
Open
weirdwater wants to merge 3 commits into
Open
Conversation
alihcsumer
approved these changes
Jun 24, 2026
Preventing shell expansion using single quotes did not work on Windows as the cmd prompt version of `npm show` would use the quote marks in the api call. The closest specification of npm package names comes from the docs where it says that it must be usable as part of a URL. We don't use encodeURIComponent() as that would escape @ and / as well, so encodeURI is enough. https://docs.npmjs.com/cli/v10/configuring-npm/package-json#name
weirdwater
force-pushed
the
fix/windows-audit
branch
from
5ff7dae to
fcd4dd0
Compare
alihcsumer
approved these changes
Jun 25, 2026
stdagkalakis
approved these changes
Jun 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains
What is the purpose of this PR?
Preventing shell expansion using single quotes did not work on Windows as the cmd prompt version of
npm showwould use the quote marks in the api call.The closest specification of npm package names comes from the docs where it says that it must be usable as part of a URL. We don't use encodeURIComponent() as that would escape @ and / as well, so encodeURI is enough.
https://docs.npmjs.com/cli/v10/configuring-npm/package-json#name
Relevant changes
What should be covered while testing?
Audit command works on windows, mac, and linux.