Skip to content

Added mcdisplay section to FlatEllipse_finite_mirror component#2521

Merged
willend merged 2 commits into
mccode-dev:mainfrom
mads-bertelsen:FlatEllipse_finite_mcdisplay
Jun 26, 2026
Merged

Added mcdisplay section to FlatEllipse_finite_mirror component#2521
willend merged 2 commits into
mccode-dev:mainfrom
mads-bertelsen:FlatEllipse_finite_mcdisplay

Conversation

@mads-bertelsen

@mads-bertelsen mads-bertelsen commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Free-form text area

Please describe what your PR is adding in terms of features or bugfixes:
Added mcdisplay section to FlatEllipse_finite_mirror component

The NMO component inherits from this, so it gets McDisplay too.

Closes #2289


Development OS / boundary conditions

Please describe what OS you developed and tested your additions on, and if any special dependencies are required:
Mac OS X 14.8.7


PR Checklist for contributing to McStas/McXtrace

For a coherent and useful contribution to McStas/McXtrace, please fill in relevant parts of the checklist:

  • My contribution includes patches to an existing component file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the component (please attach as screenshot in comments!)
    • I have ensured that basic use of the component is OK (e.g. an instrument using it compiles?)
    • I have used the mctest utility to test one or more instruments making use of the component (please attach mcviewtest report as screenshot in comments)
    • I have used the mccode-clangformat tool to apply the standard McCode component indentation scheme
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
  • My contribution includes patches to an existing instrument file

    • I have used the mcdoc utility and rendered a reasonable documentation page for the instrument (please attach as screenshot in comments!)
    • I have used the mctest utility to test the instrument (please attach mcviewtest report as screenshot in comments)
    • I have used the mcrun --c-lint "linter" and followed advice to remove most / all warnings that are raised
  • My PR is meant to fix a specific, existing issue

  • My contribution contains something else

    • Explanation is added in free form text above or below the checklist

@mads-bertelsen

Copy link
Copy Markdown
Contributor Author
Screenshot 2026-06-26 at 11 56 45

@mads-bertelsen mads-bertelsen requested a review from willend June 26, 2026 09:58
@mads-bertelsen

Copy link
Copy Markdown
Contributor Author

One issue with the components using conics is that SCATTER can not be called from within their functions, so the ray traces within the components are not accurate which is a pity.

@willend

willend commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Thanks @mads-bertelsen will have a look later today / potentially next week

@willend

willend commented Jun 26, 2026

Copy link
Copy Markdown
Contributor

Looks good @mads-bertelsen, merging

@willend willend merged commit 4b4300e into mccode-dev:main Jun 26, 2026
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG]: McStas NMO (“FlatMirror…") component does not have a functional DISPLAY section

2 participants