MLE-30243 Ensure password is sanitized in any logging#1950
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Ensures the ConnectionString helper in marklogic-client-api won’t expose passwords if it’s ever logged/printed, addressing MLE-30243.
Changes:
- Added
ConnectionString.toString()that redacts the password portion. - Added unit tests verifying password redaction both with and without a database path segment.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| marklogic-client-api/src/main/java/com/marklogic/client/impl/ConnectionString.java | Overrides toString() to return a redacted connection string (password masked). |
| marklogic-client-api/src/test/java/com/marklogic/client/impl/DatabaseClientPropertySourceTest.java | Adds tests asserting ConnectionString.toString() does not reveal the password. |
rjdew-progress
force-pushed
the
MLE-30243
branch
from
34b7d00 to
75fa14d
Compare
RitaChen609
approved these changes
Jun 24, 2026
jonmille
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.