Conversation
|
Nice! I'll have a look at using https://github.com/ambaxter/spatial-rs for my implementation, but yeah, I have a feeling it might be complex to implement… |
|
I've tested this PR on one synthetic polygon. Calculation took about one minute. It looks like no effect compared original version: |
|
Something you may want to consider: I like the fact that the code is just 150 lines + a heap base priority queue implementation; e.g. I'm planning to use this in Java on Android. By accepting this pull request you add ~500+50 lines of dependencies, this hurts portability between languages a lot, and may make it harder to understand the algorithm. |
|
@TWiStErRob yes, that's the main reason I haven't pursued merging this much. |
|
Superceded by #127, which achieves a huge speedup with a much smaller change. |
Fixes #7. Makes the implementation considerably more complex though, and I have yet to set up a real world benchmark on a variety of polygons — preliminary results show ~3-4 faster times after warming up, which is less than I hoped for. The speedup may be bigger on other platforms though.