Skip to content

Fix VC Function Substitution#267

Open
rcosta358 wants to merge 2 commits into
track-simplification-passesfrom
fix-vc-function-substitution
Open

Fix VC Function Substitution#267
rcosta358 wants to merge 2 commits into
track-simplification-passesfrom
fix-vc-function-substitution

Conversation

@rcosta358

Copy link
Copy Markdown
Collaborator

Description

This PR fixes VC function substitution so function equality premises are removed after they are used to rewrite later premises or the conclusion, similarly to normal VC substitution.

Example

f(x) == 0
f(y) == f(x) + 1

simplified to

f(x) == 0
f(y) == 0 + 1

and now simplifies to 

f(y) == 0 + 1

Related Issue

None.

Type of change

  • Bug fix
  • New feature
  • Documentation update
  • Code refactoring

Checklist

  • Added/updated tests
  • mvn test passes locally
  • Updated docs/README if behavior or API changed

@rcosta358 rcosta358 self-assigned this Jun 24, 2026
@rcosta358 rcosta358 added bug Something isn't working simplification Related to the simplification of expressions labels Jun 24, 2026
@rcosta358 rcosta358 force-pushed the fix-vc-function-substitution branch from bdc9dad to 2d2db90 Compare June 24, 2026 16:46

@CatarinaGamboa CatarinaGamboa left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm fine if this works. Can you add an issue with this situation so that we know we might still need to fix it down the line?

@rcosta358

Copy link
Copy Markdown
Collaborator Author

Sure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working simplification Related to the simplification of expressions

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants