Add 60 minute timeout to CI jobs#922
Conversation
|
👋 Thanks for assigning @tnull as a reviewer! |
tnull
left a comment
tnull
left a comment
There was a problem hiding this comment.
We ran out of our CI limit largely from ldk-node.
Not opposed to this change, but note that it's mainly ldk-node as rust-lightning has switched to a hosted runner for a while. The more important fix here is to also switch LDK Node over for all jobs where we can. I need to finally do that.
Added a commit for that |
|
rip |
|
we're back? |
We ran out of our CI limit largely from ldk-node. We had a few jobs this week run for multiple hours because of a hanging test. Add 60 minute timeout to all our jobs to prevent this in the future.
benthecarman
force-pushed
the
ci-timeouts
branch
2 times, most recently
from
16367cd to
222ba6a
Compare
Run the Rust build/test matrix, linting, docs, and benchmarks on the self-hosted runner, but keep jobs the runner cannot serve on GitHub's ubuntu-latest: - Docker-based integration tests (cln, eclair, lnd, python, kotlin) and the Postgres/VSS service-container jobs, since the self-hosted runner has no Docker installed. - Third-party node-action jobs (semver checks, security audit, nightly rustfmt), since the runner is too old to load actions that require the node24 runtime. For the jobs that stay self-hosted, adapt to the runner environment: - Pin actions/checkout to v4 and actions/cache to v4; their newer releases run on node24, which the self-hosted runner does not support. - Install the Rust toolchain in its own step so rustup and cargo land on PATH for the steps that follow; invoking them in the same step as the rustup install fails because PATH is not refreshed mid-step. Assisted by Claude Code. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
benthecarman
force-pushed
the
ci-timeouts
branch
from
222ba6a to
c2ee8b0
Compare
| steps: | ||
| - name: Checkout source code | ||
| uses: actions/checkout@v6 | ||
| uses: actions/checkout@v4 |
There was a problem hiding this comment.
Doing all these downgrades makes no sense to me. @TheBlueMatt any reason we can't update the runners to support node24?
3 participants
We ran out of our CI limit largely from ldk-node. We had a few jobs this week run for multiple hours because of a hanging test. Add 60 minute timeout to all our jobs to prevent this in the future.