add admission webhook validation for service export request#358
add admission webhook validation for service export request#358olamilekan000 wants to merge 1 commit into
Conversation
|
Important Review skippedAuto reviews are limited based on label configuration. 🏷️ Required labels (at least one) (1)
Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
d4a7cf9 to
4f00794
Compare
|
@olamilekan000 will review this bit later. Need few days to sort some other things. Have you been able to test this while deploying kube-bind backend and trying it? |
No problem. Yes I did. Here's a screenshot
|
e5f053a to
3a2cbbf
Compare
793f1ed to
2365f57
Compare
4142391 to
4ce46f7
Compare
Signed-off-by: olalekan odukoya <odukoyaonline@gmail.com>
4ce46f7 to
55683d7
Compare
|
I almost forgot about this PR. In line with @xrstf's Tedtalk, I realize that the current PR implementation goes against the point he has raised, which I agree with. To correct this, should the PR pivot to:
|
|
make sense :) +1 on stateless |
|
yeah, CEL seems right for it |

Summary
What Type of PR Is This?
/kind feature
Related Issue(s)
Fixes 325
Release Notes