ABI: make Idris2 proofs genuinely compile + add machine-checked theorems#32
Merged
Merged
Conversation
The governance/licence-consistency check requires an SPDX-License-Identifier header on the LICENSE file and a `license` field in the manifest. The LICENSE body is MPL-2.0 text, so stamp `SPDX-License-Identifier: MPL-2.0` (matching the actual body) and set `license = "MPL-2.0"` (replacing `license-file`). Verified with standards/scripts/check-licence-consistency.sh (passes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
Make the repo's licensing single and consistent, matching the wokelangiser reference policy and the merged iseriser pattern: - Remove contradictory PMPL-1.0-or-later / Palimpsest self-claims from README badges/footers, QUICKSTART, RSR_OUTLINE, STATE-VISUALIZER, and machine-readable governance (META, stapeln, deny.toml allow-list, copilot/AGENTIC SPDX directives, Trust/Must LICENSE-content checks, per-project CLAUDE.md). - Encode the docs split in REUSE dep5: *.adoc/*.md/docs/** -> CC-BY-SA-4.0, everything else -> MPL-2.0. - READMEs show MPL-2.0 (code) + CC-BY-SA-4.0 (docs) badges; full texts live in LICENSES/; root LICENSE stays MPL-2.0 for GitHub's licence chip. Preserves legitimate non-self references: cargo-deny's AGPL deny-list, the "never use AGPL" estate policy, and the Contributor Covenant CoC. Verified: standards/scripts/check-licence-consistency.sh passes; no residual PMPL/Palimpsest self-claims remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
The scaffolded ABI under src/interface/abi was never compiler-checked.
This makes all four modules build cleanly (zero errors, zero warnings)
with /usr/local/bin/idris2 0.7.0 and adds real machine-checked theorems.
Types.idr:
- Replace %runElab thisPlatform (ElabReflection not enabled) with plain Linux.
- DecEq Result: replace uncompilable "decEq _ _ = No absurd" catch-all with
explicit off-diagonal No (\case Refl impossible) cases for all 56 distinct
ordered constructor pairs.
- createHandle: solve the {auto 0 nonNull : So (ptr /= 0)} proof via
choose (ptr /= 0) instead of an unsolved Just (MkHandle ptr).
- Rename the duplicate NimObject record to NimObjectDef (it collided with the
NimObject constructor of NimTypeKind).
- Fix CPtr to return a concrete pointer-sized integer type per platform.
- Fix cSizeOf/cAlignOf which tried to pattern-match on the type-level
functions CInt/CSize (illegal); match concrete Bits widths instead.
- import Decidable.Equality.
Layout.idr:
- paddingFor: use minus (Nat has no Neg) instead of (-).
- Add sound decDivides : (n m : Nat) -> Maybe (Divides n m) via div + decEq.
- alignUpCorrect: was an unsound universally-quantified Refl proof; now a
sound decision returning Maybe (Divides align (alignUp size align)).
- checkCABI: implement decFieldsAligned over the Vect and return a real
CABICompliant witness (or Left) instead of the ?fieldsAlignedProof hole.
- offsetInBounds: was an unsound universally-quantified So; now returns
Maybe (So ...) decided via choose.
- verifyLayout: supply the erased sizeCorrect/aligned proofs explicitly
(choose + decDivides) instead of leaving them unsolved.
- Concrete nimBufferLayout/nimResultLayout: supply {sizeCorrect = Oh} and
{aligned = DivideBy k Refl}.
- nimBufferLayoutValid/nimResultLayoutValid: build the FieldsAligned witness
directly (one DivideBy per field) instead of holes; qualify layout names.
- Rename shadowing implicit n to k in Vect signatures.
- import Data.Nat, Decidable.Equality.
Foreign.idr:
- Declare prim__getString before the generation wrappers so it resolves to
the user Bits64 -> String type rather than the builtin Ptr String shape.
Proofs.idr (new):
- nimBufferCompliant, nimResultCompliant: CABICompliant proofs built directly.
- okIsZero, nullPointerIsFour, okDistinctFromError: result-encoding facts.
Buildability:
- git mv flat files into Nimiser/ABI/ to match module namespaces.
- Add nimiser-abi.ipkg (modules Types, Layout, Foreign, Proofs).
- Add **/build/, *.ttc, *.ttm to .gitignore.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idris2 ABI proofs — genuinely compile + machine-checked theorems
Part of the family-wide ABI-proofs review. The hand-written ABI did not typecheck under Idris2 0.7.0; this makes it real and verified, following the merged iseriser reference.
Systemic fixes:
decEq _ _ = No absurd→ explicit off-diagonal cases;{auto 0 nonNull}smart constructors →choose-based;paddingFor-→minus; realdecDivides/decFieldsAlignedreplacing?fieldsAlignedProof; honestoffsetInBounds;thisPlatformde-%runElab'd; buildable nested layout + ipkg; newProofs.idrwith real theorems.Verified:
idris2 --buildclean (0/0); adversarial re-verify found nobelieve_me/postulate/holes.🤖 Generated with Claude Code
Generated by Claude Code