ABI: make Idris2 proofs genuinely compile + add machine-checked theorems#40
Merged
Merged
Conversation
The governance/licence-consistency check requires an SPDX-License-Identifier header on the LICENSE file and a `license` field in the manifest. The LICENSE body is MPL-2.0 text, so stamp `SPDX-License-Identifier: MPL-2.0` (matching the actual body) and set `license = "MPL-2.0"` (replacing `license-file`). Verified with standards/scripts/check-licence-consistency.sh (passes). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
Make the repo's licensing single and consistent, matching the wokelangiser reference policy and the merged iseriser pattern: - Remove contradictory PMPL-1.0-or-later / Palimpsest self-claims from README badges/footers, QUICKSTART, RSR_OUTLINE, STATE-VISUALIZER, and machine-readable governance (META, stapeln, deny.toml allow-list, copilot/AGENTIC SPDX directives, Trust/Must LICENSE-content checks, per-project CLAUDE.md). - Encode the docs split in REUSE dep5: *.adoc/*.md/docs/** -> CC-BY-SA-4.0, everything else -> MPL-2.0. - READMEs show MPL-2.0 (code) + CC-BY-SA-4.0 (docs) badges; full texts live in LICENSES/; root LICENSE stays MPL-2.0 for GitHub's licence chip. Preserves legitimate non-self references: cargo-deny's AGPL deny-list, the "never use AGPL" estate policy, and the Contributor Covenant CoC. Verified: standards/scripts/check-licence-consistency.sh passes; no residual PMPL/Palimpsest self-claims remain. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
Make the scaffolded src/interface/abi proofs typecheck cleanly (zero errors,
zero warnings) under Idris2 0.7.0, with genuine machine-checked proofs.
Types.idr:
- Replace %runElab thisPlatform (needs ElabReflection) with plain Linux value.
- Replace the non-compiling DecEq Result catch-all (No absurd) with explicit
off-diagonal No (\case Refl impossible) for every distinct constructor pair.
- Fix createHandle to discharge the {auto So (ptr /= 0)} proof via choose.
- Drop unmatchable CInt/CSize cases in cSizeOf/cAlignOf (type synonyms reduce
to Bits32/Bits64, already covered).
- import Decidable.Equality.
Layout.idr:
- paddingFor: use minus alignment (mod ...) (Nat has no Neg).
- Add sound decDivides : (n m : Nat) -> Maybe (Divides n m) via div + decEq.
- Replace unsound alignUpCorrect (Refl over division, Bool-typed bound) with a
decision returning Maybe (Divides align (alignUp size align)).
- Implement checkCABI via decFieldsAligned (no ?fieldsAlignedProof hole).
- verifyLayout: discharge both MkStructLayout obligations with real witnesses
(choose for size bound, decDivides for alignment).
- offsetInBounds: change unsound universal So return to Maybe (So ...) via choose.
- Supply explicit erased proofs {sizeCorrect = Oh} {aligned = DivideBy 2 Refl}
on exampleOwnedLayout and exampleBorrowedLayout.
- Rename shadowing lowercase n -> len to clear implicit-bind warnings.
- import Data.Nat, Decidable.Equality.
Proofs.idr (new): machine-checked theorems
- exampleOwnedCompliant, exampleBorrowedCompliant : CABICompliant built
directly with one DivideBy per field (offset = k * alignment).
- okIsZero, errorIsOne, okNotBounds pin the result-code encoding.
Build: move flat files to Atsiser/ABI/ nested layout; add atsiser-abi.ipkg.
Add **/build/, *.ttc, *.ttm to .gitignore. No believe_me/postulate/holes.
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01DF9CcCuL4YJoqs26eHsYiA
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Idris2 ABI proofs — genuinely compile + machine-checked theorems
Part of the family-wide ABI-proofs review. The hand-written ABI did not typecheck under Idris2 0.7.0; this makes it real and verified, following the merged iseriser reference.
Systemic fixes:
decEq _ _ = No absurd→ explicit off-diagonal cases;{auto 0 nonNull}smart constructors →choose-based;paddingFor-→minus; realdecDivides/decFieldsAlignedreplacing?fieldsAlignedProof; honestoffsetInBounds;thisPlatformde-%runElab'd; buildable nested layout + ipkg; newProofs.idrwith real theorems.Verified:
idris2 --buildclean (0/0); adversarial re-verify found nobelieve_me/postulate/holes.🤖 Generated with Claude Code
Generated by Claude Code