Deprecate reexports of unsafe functions defined in Unsafe modules#561
Merged
Conversation
Deprecation of reexports was introduced in GHC9.8 so we have to define new functions to deprecate
It was forgotten by mistake
Make sure that DEPRECATED messages point to correct module and all unsafe functions are marked as deprecated
Contributor
Author
|
I think this PR is ready for review. @lehins do you have any objections? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is partial (only
Primitivemodules) implementation of stage 2 of plan described in #540 (comment) Once we're happy with implementation for primitive we can replicate it for other unsafe functions.Deprecation of reexports was introduced in GHC9.8 so we have to define new functions to deprecate. Haddocks for deprecated reexports looks like this:
