harden: reject shell=True in run_command#3132
Open
PascalThuet wants to merge 1 commit into
Open
Conversation
run_command() forwarded shell= straight to subprocess.run, so a caller passing shell=True would invoke a shell. Reject shell=True with ValueError (keeping the parameter for signature compatibility) and drop shell= from both subprocess.run calls. Enable ruff S602/S604/S605 to flag any future shell=True reintroduction, annotate the one intentional workflow shell sink with # noqa: S602, and document the shell-step execution risk in workflows/PUBLISHING.md.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of splitting #2442 into smaller, dedicated PRs. Re-derived against current
main(the #2442 branch is ~20 commits behind).What
run_command()now rejectsshell=TruewithValueErrorinstead of forwarding it tosubprocess.run. Theshellparameter is kept (defaultFalse) for signature / keyword-caller compatibility.S602/S604/S605so any futureshell=True(oros.system/popen) must be acknowledged with an explicit# noqa.ShellStep) with# noqa: S602.workflows/PUBLISHING.md.Why
run_command(shell=True)would run its argv through a shell (word-splitting, globbing, injection surface). No call site needs that mode; failing loudly prevents a future caller from silently enabling it.Validation
tests/test_utils.py::test_run_command_rejects_shell_execution_compatiblypasses.ruff check --select S602,S604,S605 src tests/test_utils.pyis clean.Independent of the other split PRs.