eslint 9 + vulnerabilities#35
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repo’s linting setup by migrating to ESLint’s flat config and updating ESLint-related dependencies, while also removing an unnecessary ESLint suppression in tests.
Changes:
- Migrates ESLint configuration from
package.json(eslintConfig/eslintIgnore) to a neweslint.config.mjsflat config. - Updates ESLint and related plugin/config versions and adjusts the
lintscript accordingly. - Cleans up
test/index.tsby removing an unused ESLint disable comment and using optional chaining inbeforeEach.
Show a summary per file
| File | Description |
|---|---|
test/index.ts |
Removes an unnecessary ESLint suppression and simplifies cancel() cleanup using optional chaining. |
package.json |
Updates ESLint/tooling dependencies and switches from inline ESLint config to flat-config-based setup. |
eslint.config.mjs |
Adds ESLint flat configuration equivalent to the previous eslintConfig/eslintIgnore settings. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 3/4 changed files
- Comments generated: 1
Comment on lines
+39
to
+43
| "eslint": "^10.5.0", | ||
| "eslint-config-prettier": "^10.1.8", | ||
| "eslint-plugin-compat": "^7.0.2", | ||
| "eslint-plugin-escompat": "^3.11.4", | ||
| "eslint-plugin-github": "^4.1.1", | ||
| "eslint-plugin-github": "^6.0.0", |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.