chore(server): migrate Server/ from npm to pnpm#870
Closed
chronicgiardia wants to merge 2 commits into
Closed
Conversation
Adds Docs/CompletionPipeline.md covering the full end-to-end flow: - Trigger modes (on-demand vs realtime/prefetch) - All five layers: EditorExtension → XPC → ExtensionService → SuggestionService middleware chain → LSP client (GitHubCopilotService) - XPC protocol methods table - LSP JSON-RPC request types and server notifications - SuggestionInjector buffer modification semantics - Accept/reject cycle with telemetry - Key source file index Co-Authored-By: Oz <oz-agent@warp.dev>
- Remove package-lock.json (npm lockfile) - Add pnpm-lock.yaml (pnpm lockfile) Server/package.json already declares "packageManager": "pnpm@10.20.0". Using npm was inconsistent with this declaration and caused pnpm to move existing node_modules to node_modules/.ignored on install. Build verified: webpack compiled successfully with 0 errors. Co-Authored-By: Oz <oz-agent@warp.dev>
Contributor
|
At the moment we are not accepting contributions to the repository. Feedback for GitHub Copilot for Xcode can be given in the Copilot community discussions. |
There was a problem hiding this comment.
Pull request overview
This PR migrates the Server/ Node.js subproject from npm’s lockfile (package-lock.json) to pnpm’s lockfile (pnpm-lock.yaml) to standardize dependency installs, and adds internal documentation describing the completion pipeline architecture.
Changes:
- Added
Server/pnpm-lock.yamland removedServer/package-lock.jsonto align installs with pnpm. - Introduced
Docs/CompletionPipeline.mddocumenting the end-to-end completion request flow and key components.
Reviewed changes
Copilot reviewed 1 out of 3 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Server/pnpm-lock.yaml | Adds pnpm lockfile for Server/ dependencies (and captures resolved versions). |
| Server/package-lock.json | Removes npm lockfile from Server/. |
| Docs/CompletionPipeline.md | Adds documentation for the completion pipeline and key source locations. |
Files not reviewed (2)
- Server/package-lock.json: Generated file
- Server/pnpm-lock.yaml: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+50
to
+52
| ### Realtime (prefetch) | ||
|
|
||
| `RealtimeSuggestionController` (in `Core/Sources/Service/`) watches for editor changes via the AX API (`XcodeInspector`) and calls `prefetchRealtimeSuggestions` on every keystroke after a debounce delay. The prefetched suggestion is cached in the filespace so it can be displayed immediately when the user pauses. |
Comment on lines
+1
to
+5
| lockfileVersion: '9.0' | ||
|
|
||
| settings: | ||
| autoInstallPeers: true | ||
| excludeLinksFromLockfile: false |
Comment on lines
+49
to
+53
| specifier: ^5.8.3 | ||
| version: 5.9.3 | ||
| webpack: | ||
| specifier: ^5.99.9 | ||
| version: 5.107.2(postcss@8.5.15)(webpack-cli@6.0.1) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes
Server/package-lock.jsonand replaces it withServer/pnpm-lock.yaml, aligning the lockfile with the package manager already declared inpackage.json.Motivation
Server/package.jsondeclares:Despite this,
package-lock.json(an npm artifact) was committed to the repo. This causedpnpm installto warn and move existingnode_modulesentries tonode_modules/.ignored, requiring a full re-download. Using npm also bypasses the pnpm content-addressable store, making installs slower.Changes
Server/package-lock.json— deletedServer/pnpm-lock.yaml— added (generated by pnpm v10.33.0)Verification