[Dependencies] Updating Credfeto.Docker.HealthCheck.Http.Client (Docker healthcheck http client) to 0.0.72.928 by github-actions[bot] · Pull Request #383 · funfair-tech/BuildBot

github-actions · 2026-06-23T10:24:19Z

Description

How Has This Been Tested

All unit tests pass.
All integration tests pass.
Manual Testing:

Types of changes

Docs change
Refactoring
Dependency upgrade
Additional Unit Tests\Integration Tests
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing
functionality to change)
Removed no-longer used code

Deployment Configuration Changes

Requires deployment configuration changes as specified below and in CHANGELOG.md

Checklist

I have added tests to cover my changes.
Unreleased section of CHANGELOG.md has been updated with details of this PR.

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 · 2026-06-23T15:24:27Z

Fixed the NullLogger finding from code review in 00e0cde — replaced NullLogger.Instance with a minimal console LoggerFactory so HealthCheckFailed errors surface in container logs when the health check HTTP call fails.

dnyw4l3n13 · 2026-06-23T15:42:05Z

All CI checks pass, code review complete (3 rounds, no unresolved findings), and security review complete (no findings). Auto-merge has been enabled.

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

credfeto · 2026-06-23T15:50:00Z

Super-linter summary

Language	Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

dnyw4l3n13 · 2026-06-23T15:50:17Z

Rebased onto origin/main — resolved CHANGELOG.md conflict by keeping entries from both sides. Force-pushed successfully.

CI checks are now pending. Waiting for all required checks to complete before proceeding.

dnyw4l3n13 · 2026-06-23T15:52:36Z

CI in progress — build-pre-release is still pending after the recent rebase. Stopping here; will re-check once all required checks complete.

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 · 2026-06-27T14:23:22Z

Status update: All required CI checks pass. The AI review loop was completed in a prior session (code review: 2 rounds with no outstanding findings; security review: no findings). Auto-merge is enabled and the PR is awaiting human approval.

Summary of changes in this PR:

Updated Credfeto.Docker.HealthCheck.Http.Client to 0.0.72.928 (API change required passing ILogger to HealthCheckClient.ExecuteAsync)
Switched from NullLogger.Instance to a console logger factory so HealthCheckFailed errors surface in container logs
Cleaned up stale CHANGELOG entries (superseded 0.0.61.659 and FunFair.Test.Common 6.2.17.1982 entries removed)

dnyw4l3n13 · 2026-06-27T14:36:43Z

Workflow board updated to Human Review.

Current state:

All required CI checks pass
Branch is up to date with origin/main
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Auto-merge is enabled (enabled 2026-06-23)

Awaiting human approval to merge.

dnyw4l3n13 · 2026-06-27T17:31:42Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Auto-merge is enabled — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-27T17:34:39Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main (rebased on 4a75bc5c)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Auto-merge is enabled — will trigger once a required reviewer approves

Awaiting human approval.

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 · 2026-06-27T17:45:10Z

Rebased onto origin/main — resolved CHANGELOG.md conflict by keeping entries from both sides (Meziantou.Analyzer 3.0.115 from main, Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 from this PR). Force-pushed successfully.

CI checks are now queuing. Auto-merge is already enabled and will trigger once all required checks pass and the PR is approved.

dnyw4l3n13 · 2026-06-27T17:50:31Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main (no rebase needed)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Auto-merge is enabled — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-27T18:30:07Z

AI review complete — no findings from either code review or security review.

Code review: All candidates refuted. Logger disposal timing is safe (C# using declaration disposes after await completes); checkUrl nullability is safe ([NotNullWhen(true)] on the out-param guarantees non-null in the if-block).
Security review: No vulnerabilities. checkUrl originates from trusted CLI args and is validated as an absolute URI before use; console logger exposes only exception details.

Auto-merge enabled.

dnyw4l3n13 · 2026-06-27T18:44:10Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Workflow board updated to Human Review
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-27T23:26:57Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Workflow board previously set to Human Review
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-27T23:35:42Z

Status check (2026-06-27): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Workflow board previously set to Human Review
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-28T02:32:48Z

Status check (2026-06-28): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Workflow board previously set to Human Review (GraphQL board update skipped — API rate limit)
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-28T02:35:59Z

Status check (2026-06-28): No changes required.

All required CI checks pass
Branch is up to date with origin/main (merge base: cc5c24cb — Meziantou.Analyzer 3.0.115)
AI code review complete (2 rounds, no outstanding findings)
AI security review complete (no findings)
Workflow board status: Human Review
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-28T03:35:15Z

Status check (2026-06-28): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb — Meziantou.Analyzer 3.0.115)
AI code review complete (no outstanding findings)
AI security review complete (no findings)
Workflow board status: Human Review
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-28T07:25:53Z

Status check (2026-06-28): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb — Meziantou.Analyzer 3.0.115)
AI code review complete (no outstanding findings)
AI security review complete (no findings)
Workflow board status: Human Review (GraphQL board update skipped — API rate limit)
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

dnyw4l3n13 · 2026-06-28T07:45:50Z

Status check (2026-06-28): No changes required.

All required CI checks pass
Branch is up to date with origin/main (tip: cc5c24cb — Meziantou.Analyzer 3.0.115)
AI code review complete (no outstanding findings)
AI security review complete (no findings)
Workflow board status: Human Review (updated successfully)
Auto-merge is enabled (since 2026-06-23) — will trigger once a required reviewer approves

Awaiting human approval.

…er healthcheck http client) to 0.0.72.928

…in 0.0.72.928 Credfeto.Docker.HealthCheck.Http.Client 0.0.72.928 added a required ILogger parameter to ExecuteAsync. Pass NullLogger.Instance since the health check runs before the host and DI container are initialised. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

… errors NullLogger.Instance was silently discarding the HealthCheckFailed(uri, exception) Error-level log that ExecuteAsync emits on connection failures, TLS errors, and DNS failures. The ILogger parameter was added to 0.0.72.928 specifically to expose this diagnostic; use a minimal console LoggerFactory so operators can see why a health check failed. Prompt: Work on pull request #383 in funfair-tech/BuildBot.

…9 changelog entry The [Unreleased] section contained both the old (0.0.61.659) and new (0.0.72.928) versions of Credfeto.Docker.HealthCheck.Http.Client. Since 0.0.61.659 was never shipped in a release, only the latest version should appear in [Unreleased].

The [Unreleased] section contained FunFair.Test.Common 6.2.17.1982 alongside the newer 6.3.1.2342 in the same block. Since 6.2.17.1982 was never shipped in a release, the intermediate version entry adds noise to the changelog without value.

dnyw4l3n13 · 2026-06-28T10:44:59Z

Rebased onto origin/main — resolved CHANGELOG.md conflict by keeping entries from both sides (null guards for BotService constructor from main, ILogger fix for HealthCheckClient.ExecuteAsync from this PR). Force-pushed successfully.

CI checks are now pending. Stopping here; will re-check once all required checks complete.

github-actions Bot assigned credfeto Jun 23, 2026

github-actions Bot added the auto-pr Pull request created automatically label Jun 23, 2026

dnyw4l3n13 self-assigned this Jun 23, 2026

dnyw4l3n13 added a commit that referenced this pull request Jun 23, 2026

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

4fc795e

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 reviewed Jun 23, 2026

View reviewed changes

Comment thread src/BuildBot/Program.cs Outdated

dnyw4l3n13 reviewed Jun 23, 2026

View reviewed changes

Comment thread src/BuildBot/Program.cs

dnyw4l3n13 marked this pull request as ready for review June 23, 2026 15:41

dnyw4l3n13 requested a review from a team as a code owner June 23, 2026 15:41

dnyw4l3n13 enabled auto-merge June 23, 2026 15:42

dnyw4l3n13 added a commit that referenced this pull request Jun 23, 2026

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

40e99d4

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch from 00e0cde to 283bd9e Compare June 23, 2026 15:49

dnyw4l3n13 added a commit that referenced this pull request Jun 24, 2026

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

b38d547

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch from 283bd9e to bf302a4 Compare June 24, 2026 13:44

dnyw4l3n13 added a commit that referenced this pull request Jun 24, 2026

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

0b612ce

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch from bf302a4 to 487b25a Compare June 24, 2026 20:59

dnyw4l3n13 reviewed Jun 24, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

dnyw4l3n13 reviewed Jun 24, 2026

View reviewed changes

Comment thread CHANGELOG.md Outdated

dnyw4l3n13 added a commit that referenced this pull request Jun 27, 2026

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

69c88b1

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch from 11a4794 to b975bb3 Compare June 27, 2026 17:45

credfeto and others added 6 commits June 28, 2026 10:44

[Dependencies] Updating Credfeto.Docker.HealthCheck.Http.Client (Dock…

b3bb103

…er healthcheck http client) to 0.0.72.928

chore: update changelog for ILogger fix in HealthCheckClient.ExecuteA…

8161d9f

…sync Prompt: Work on pull request #383 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch from b975bb3 to 5fe4cd7 Compare June 28, 2026 10:44

credfeto approved these changes Jun 28, 2026

View reviewed changes

dnyw4l3n13 merged commit 2b17739 into main Jun 28, 2026
20 checks passed

dnyw4l3n13 deleted the depends/update-credfeto.docker.healthcheck.http.client/0.0.72.928 branch June 28, 2026 10:53

Uh oh!

Conversation

github-actions Bot commented Jun 23, 2026

Description

How Has This Been Tested

Types of changes

Deployment Configuration Changes

Checklist

Uh oh!

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

credfeto commented Jun 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Super-linter summary

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

Uh oh!

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

dnyw4l3n13 commented Jun 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

credfeto commented Jun 23, 2026 •

edited

Loading