test(discord): Add null-guard branch coverage for BotService constructor by github-actions[bot] · Pull Request #377 · funfair-tech/BuildBot

github-actions · 2026-06-22T11:09:33Z

Summary

Adds a reflection-based test to cover the bot == null guard in BotService constructor, bringing BotService to 100% line and branch coverage.
The NX0002 analyser rule prevents using null! directly, so the constructor is invoked via ConstructorInfo.Invoke with a null argument instead.

Coverage status after this PR

Assembly	Line	Branch
BuildBot.ServiceModel	100%	100%
BuildBot.Discord	~93% line (infrastructure gaps tracked in #374)	see #374
BuildBot.Health	100%	100%
BuildBot.Json	100%	100%
BuildBot.Watchtower	100%	100%
BuildBot.CloudFormation	100%	100%
BuildBot.GitHub	100%	100%
BuildBot	100%	100%

Remaining gaps in BuildBot.Discord (DiscordChannelAdapter and the live-infrastructure methods of DiscordSocketClientAdapter) are infrastructure-dependent and tracked in issue #374.

Closes #356

Test plan

All 233 tests pass
BotService reaches 100% line and branch coverage
dotnet buildcheck passes with no errors

dnyw4l3n13 · 2026-06-23T16:14:55Z

[Code Review — Pre-existing gap] BotService.cs lines 27-28 assign botMessageChannel and botReleaseMessageChannel without null guards, but both are immediately dereferenced inside the Rx chain (lines 31 and 41). If either is passed as null, a NullReferenceException fires deep in Rx internals with no hint that it was a missing null guard. This is pre-existing and outside this PR's diff, but it is the subject matter this PR is extending (null-guard coverage), so flagging it here for tracking. Consider adding ?? throw new ArgumentNullException(nameof(...)) guards for the two channel parameters in BotService.cs.

- Use GetConstructor with explicit parameter types instead of Assert.Single on GetConstructors(), avoiding confusing failure messages if a second constructor is ever added - Remove unnecessary MessageChannel allocations — the constructor throws before touching the channel parameters, so null suffices for those args - Assert ParamName == "bot" on the caught ArgumentNullException so a mis-targeted guard is detected rather than silently passing Prompt: Work on pull request #377 in funfair-tech/BuildBot.

…nstructor Add `?? throw ArgumentNullException` guards for botMessageChannel and botReleaseMessageChannel — they were assigned without guards and would cause a NullReferenceException deep in Rx internals if passed null. Add corresponding constructor tests to cover both new guards. Prompt: Work on pull request #377 in funfair-tech/BuildBot.

…structor Prompt: Work on pull request #377 in funfair-tech/BuildBot.

dnyw4l3n13 · 2026-06-27T06:09:24Z

Fixed in ee1e59b — added ?? throw new ArgumentNullException(nameof(...)) guards for both botMessageChannel and botReleaseMessageChannel in BotService.cs, and added corresponding constructor tests (Constructor_ThrowsArgumentNullException_WhenBotMessageChannelIsNull and Constructor_ThrowsArgumentNullException_WhenBotReleaseMessageChannelIsNull) to cover both new guards.

Replace three structurally identical Constructor_ThrowsArgumentNullException_When* [Fact] methods with a single [Theory] + [MemberData] test, using an index to select which parameter is null. Removes the GetConstructor call duplicated verbatim three times and satisfies the project rule requiring parameterised tests over duplicated methods. Prompt: Work on pull request #377 in funfair-tech/BuildBot.

credfeto · 2026-06-27T06:29:26Z

Super-linter summary

Language	Validation result

All files and directories linted successfully

For more information, see the GitHub Actions workflow run

Powered by Super-linter

dnyw4l3n13 · 2026-06-27T06:29:33Z

All work complete. Summary of changes on this PR:

0e24809 — Strengthened the existing bot null-guard test: use GetConstructor with explicit parameter types, pass [null, null, null] to avoid unnecessary allocations, assert ParamName == "bot"
ee1e59b — Added null guards for botMessageChannel and botReleaseMessageChannel in BotService.cs, with corresponding tests
bf6ec38 — Refactored three identical [Fact] null-guard tests into a single [Theory] with [MemberData] per project rules

Code review and security review both passed clean. Auto-merge enabled.

Adds a reflection-based test to cover the null-bot argument guard in BotService, bringing BotService to 100% line and branch coverage. The null! operator cannot be used directly due to the NX0002 analyser rule, so the constructor is invoked via reflection. Prompt: Work on issue #356 in funfair-tech/BuildBot. Closes #356

- Use GetConstructor with explicit parameter types instead of Assert.Single on GetConstructors(), avoiding confusing failure messages if a second constructor is ever added - Remove unnecessary MessageChannel allocations — the constructor throws before touching the channel parameters, so null suffices for those args - Assert ParamName == "bot" on the caught ArgumentNullException so a mis-targeted guard is detected rather than silently passing Prompt: Work on pull request #377 in funfair-tech/BuildBot.

…nstructor Add `?? throw ArgumentNullException` guards for botMessageChannel and botReleaseMessageChannel — they were assigned without guards and would cause a NullReferenceException deep in Rx internals if passed null. Add corresponding constructor tests to cover both new guards. Prompt: Work on pull request #377 in funfair-tech/BuildBot.

…structor Prompt: Work on pull request #377 in funfair-tech/BuildBot.

Replace three structurally identical Constructor_ThrowsArgumentNullException_When* [Fact] methods with a single [Theory] + [MemberData] test, using an index to select which parameter is null. Removes the GetConstructor call duplicated verbatim three times and satisfies the project rule requiring parameterised tests over duplicated methods. Prompt: Work on pull request #377 in funfair-tech/BuildBot.

dnyw4l3n13 · 2026-06-27T17:43:12Z

Rebased the branch onto origin/main to pick up the Meziantou.Analyzer 3.0.115 dependency update (commit cc5c24cb). Force-pushed successfully; CI is now running on the rebased tip. Auto-merge remains enabled — will merge automatically once checks pass.

dnyw4l3n13 · 2026-06-27T17:48:15Z

All CI checks pass and auto-merge is enabled. The PR is currently blocked on REVIEW_REQUIRED — the previous approval from @credfeto was dismissed when the branch was rebased and force-pushed (2026-06-27T17:43). No further code changes are needed; the PR is ready and waiting for a human approval to satisfy the branch-protection rule before auto-merge can complete.

dnyw4l3n13 · 2026-06-27T20:30:41Z

Status update (2026-06-27): All CI checks continue to pass. Workflow board updated to Human Review. Auto-merge remains enabled and is waiting for a human approval to satisfy the branch-protection REVIEW_REQUIRED rule — the previous approval from @credfeto was dismissed when the branch was force-pushed after the rebase on 2026-06-27T17:43. No further code changes are needed.

dnyw4l3n13 · 2026-06-27T20:36:22Z

Status check (2026-06-27): No new activity to action. All CI checks pass, code review and security review both passed clean, auto-merge remains enabled, and the workflow board is confirmed at Human Review. The PR is waiting for a human approval to satisfy the branch-protection REVIEW_REQUIRED rule — the previous approval from @credfeto was dismissed when the branch was force-pushed after the rebase on 2026-06-27T17:43. No further code changes are needed.

github-actions Bot assigned dnyw4l3n13 Jun 22, 2026

github-actions Bot added the auto-pr Pull request created automatically label Jun 22, 2026

dnyw4l3n13 added C# C# Source Files Tech Debt Technical debt AI-Work Work for an AI Agent labels Jun 22, 2026

dnyw4l3n13 mentioned this pull request Jun 22, 2026

[Coverage] Increase code coverage to 100% across all projects #356

Closed

credfeto previously approved these changes Jun 22, 2026

View reviewed changes

dnyw4l3n13 reviewed Jun 23, 2026

View reviewed changes

Comment thread src/BuildBot.Discord.Tests/Services/BotServiceTests.cs Outdated

dnyw4l3n13 reviewed Jun 23, 2026

View reviewed changes

Comment thread src/BuildBot.Discord.Tests/Services/BotServiceTests.cs Outdated

dnyw4l3n13 reviewed Jun 23, 2026

View reviewed changes

Comment thread src/BuildBot.Discord.Tests/Services/BotServiceTests.cs Outdated

dnyw4l3n13 dismissed credfeto’s stale review via b04c00f June 23, 2026 16:27

dnyw4l3n13 force-pushed the feature/356-discord-botservice-null-coverage branch from b04c00f to c2aa353 Compare June 25, 2026 10:03

dnyw4l3n13 force-pushed the feature/356-discord-botservice-null-coverage branch from c2aa353 to 0e24809 Compare June 26, 2026 03:04

dnyw4l3n13 added a commit that referenced this pull request Jun 27, 2026

changelog: Added null guards for channel parameters in BotService con…

517a8cd

…structor Prompt: Work on pull request #377 in funfair-tech/BuildBot.

dnyw4l3n13 reviewed Jun 27, 2026

View reviewed changes

Comment thread src/BuildBot.Discord.Tests/Services/BotServiceTests.cs Outdated

dnyw4l3n13 marked this pull request as ready for review June 27, 2026 06:29

dnyw4l3n13 requested a review from a team as a code owner June 27, 2026 06:29

dnyw4l3n13 enabled auto-merge June 27, 2026 06:29

dnyw4l3n13 added 3 commits June 27, 2026 17:42

dnyw4l3n13 added 2 commits June 27, 2026 17:42

changelog: Added null guards for channel parameters in BotService con…

eb651f7

…structor Prompt: Work on pull request #377 in funfair-tech/BuildBot.

dnyw4l3n13 force-pushed the feature/356-discord-botservice-null-coverage branch from bf6ec38 to 3f41659 Compare June 27, 2026 17:42

credfeto approved these changes Jun 28, 2026

View reviewed changes

dnyw4l3n13 merged commit ab2d578 into main Jun 28, 2026
20 checks passed

dnyw4l3n13 deleted the feature/356-discord-botservice-null-coverage branch June 28, 2026 10:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

test(discord): Add null-guard branch coverage for BotService constructor#377

test(discord): Add null-guard branch coverage for BotService constructor#377
dnyw4l3n13 merged 5 commits into
mainfrom
feature/356-discord-botservice-null-coverage

github-actions Bot commented Jun 22, 2026 •

edited by dnyw4l3n13

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

Uh oh!

credfeto commented Jun 27, 2026 •

edited

Loading

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

github-actions Bot commented Jun 22, 2026 • edited by dnyw4l3n13 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Coverage status after this PR

Test plan

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dnyw4l3n13 commented Jun 23, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

Uh oh!

credfeto commented Jun 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Super-linter summary

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

dnyw4l3n13 commented Jun 27, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

github-actions Bot commented Jun 22, 2026 •

edited by dnyw4l3n13

Loading

credfeto commented Jun 27, 2026 •

edited

Loading