Skip to content

Add WAL process-kill crashpoints#626

Merged
flyingrobots merged 1 commit into
mainfrom
cycle/577-process-kill-crashpoint-runner
Jun 28, 2026
Merged

Add WAL process-kill crashpoints#626
flyingrobots merged 1 commit into
mainfrom
cycle/577-process-kill-crashpoint-runner

Conversation

@flyingrobots

Copy link
Copy Markdown
Owner

Closes #577

Summary

  • Add wal_process_crashpoints in echo-dind-tests, using a parent/child test harness that kills child processes after committed WAL material and before transaction commit.
  • Promote process.kill.after_wal_commit from future descriptor to ProcessKill execution posture in the WAL crashpoint manifest.
  • Add the exact witness to durability-release and update WAL/workflow/changelog/hardening-matrix signposts.

Validation

  • cargo test -p echo-dind-tests wal_process_crashpoints -- --nocapture
  • cargo test -p warp-core --test causal_wal_hardening_tests crashpoint_manifest_marks_process_kill_as_available_runner
  • cargo test -p xtask test_slice_durability_release_stays_explicit
  • cargo clippy -p echo-dind-tests --all-targets -- -D warnings
  • cargo clippy -p warp-core --test causal_wal_hardening_tests -- -D warnings
  • cargo test -p echo-dind-tests
  • cargo fmt --check
  • npx markdownlint-cli2 CHANGELOG.md docs/topics/WAL.md docs/workflows.md docs/design/causal-wal-hardening-matrix.md
  • git diff --check
  • scripts/ban-nondeterminism.sh
  • pre-commit hook: echo-dind-tests and warp-core clippy/check plus markdownlint
  • pre-push hook: echo-dind-tests --lib, full causal_wal_hardening_tests, and markdown formatting

@coderabbitai

coderabbitai Bot commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

Warning

Review limit reached

@flyingrobots, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 29 seconds. Learn how PR review limits work.

Your organization has run out of usage credits. Purchase more credits in the billing tab to continue.

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: ASSERTIVE

Plan: Pro

Run ID: 6ee30459-ede4-4001-b5c5-184b1f3ae932

📥 Commits

Reviewing files that changed from the base of the PR and between 8e89de4 and fe8c2f6.

📒 Files selected for processing (8)
  • CHANGELOG.md
  • crates/echo-dind-tests/src/lib.rs
  • crates/warp-core/src/causal_wal.rs
  • crates/warp-core/tests/causal_wal_hardening_tests.rs
  • docs/design/causal-wal-hardening-matrix.md
  • docs/topics/WAL.md
  • docs/workflows.md
  • xtask/src/main.rs
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch cycle/577-process-kill-crashpoint-runner

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Code Lawyer update

Item Status Evidence Resolving commit
#577 Process-Kill Crashpoint Runner Resolved wal_process_crashpoints kills child processes after committed WAL material and before transaction commit, then verifies recovery preserves committed history and excludes uncommitted tails. fe8c2f6
Crashpoint manifest Resolved process.kill.after_wal_commit is now WalCrashpointExecution::ProcessKill; crashpoint_manifest_marks_process_kill_as_available_runner passed locally and in CI. fe8c2f6
Release gate witness Resolved cargo test -p echo-dind-tests wal_process_crashpoints is wired into cargo xtask test-slice durability-release. fe8c2f6
CI Clean 36/36 PR checks passed, including CI, det-gates, Security Audit, SPDX Header Check, and Materialization Determinism. fe8c2f6
Review threads Clean GraphQL reviewThreads.totalCount is 0; no requested-change reviews. fe8c2f6
CodeRabbit Clean CodeRabbit status is SUCCESS; top-level note is only rate limit / credits, with no actionable review threads. fe8c2f6

@flyingrobots flyingrobots merged commit 06ddc4c into main Jun 28, 2026
36 checks passed
@flyingrobots flyingrobots deleted the cycle/577-process-kill-crashpoint-runner branch June 28, 2026 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

[GP5-S4] Process-Kill Crashpoint Runner

1 participant